[#7110] - Incorrect check for response header Oauth2 Client
- Fixed in Code Base
- 16 Jul 2016
- Medium
- Build: staging
- # 7110
- Diff
- AteDev:oauth2ClientResponseHeaderCT
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
In Oauth2 Client, there is an incorrect check when we want to get access token back from http post.
Some time (maybe all time) there is charset added in the content-type contained in reponse header.
How to test
You can download and install this component here
You need to edit this file: controller to add your client ID/Secret from your linkedin app
If you dont use localhost remove/comment this line
- Go to yourdomain/index.php/test
- Click "Sign in with Linkedin", apply app, you will see the return token from linkedin (incorrect array)
- Apply patch, repeat steps and you will see perfect array.
PS
I tested whith the Linkedin api, this add in content-type "application/json;charset:utf8"
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
Added component to help test (finally got time ...), sorry for this hard test :)
@AteDev I tried to test this but your test scenario is not working.
The error I get is that the redirect URI is incorrect, whatever I config and test can't seem to get through the first part to generate the incorrect array error.
Please describe a complete test scenario
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7110.
I have tested this item
Omg! Too much work to test this :P
I received the following response without this patch:
Array
(
[{"access_token":"XXXXXX","expires_in":5183484}] =>
[created] => 1467196746
)
After the patch:
Array
(
[access_token] => XXXXXX
[expires_in] => 5182960
[created] => 1467197270
)
The response header content type is indeed application/json;charset:utf8
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7110.
Found the problem, sef is by default enabled.
Them you will get other URLs when I disabled it i could start the test with the test component.
Before patch i got:
array(2) { ["{"access_token":"AQWokNE7VFc746UHNuQzg_Ygbc8BsEFEG66Lrj5KPWGM_ievtdZRbCwajlWVbNZH8GFcZ0NvRE-JgzlZ-4GI3rQa4Gd0UtLdRKr2wIMHOM-MhTRGZWtP2AwaglkbT241fAxMYKk8NHh5QLKhRcjdY6yiN0S2GVUvVajIfUfamF1Gn38nlf0","expires_in":5183731}"]=> string(0) "" ["created"]=> int(1467239441) }
After patch i got:
array(3) { ["access_token"]=> string(179) "AQXSUJxZwgRZi1jkG7lD3wEL02p9FFPbgNat03pW5mADVht9VV75bzF4EJQd2ma9LyXAnJXYv8X_RVXKC5b4xEYVbW5hyOGglypddf173umlmtQZamLH6_GVjH4KEZscwa6O69ifqXAtU5Yg7J4u3NJ8C2RGZgg4c7s5DPSfoKSMTll3DZs" ["expires_in"]=> int(5183863) ["created"]=> int(1467239309) }
Is this correct?
Yes that's right. You should mark test as success.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7110.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7110.
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Milestone |
Added: |
||
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-16 05:18:02 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
@AteDev Thanks for your PR. Just to make travis happy see here: AteDev#1
If you have one ready please make a comment so all gets notified that you have on. As only on changing the comment we don't get a notification. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7110.