[#7106] - [#33445] RTL Chosen Select causes the page to disappear
- Closed
- 11 Jun 2015
- Medium
- Build: staging
- # 7106
- Diff
- demis-palma:patch-2
- Foreign ID 33445
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR fixes a long time known problem already confirmed, but still present.
How to reproduce
The bug affects Google Chrome, Firefox and Internet Explorer. Opera browser is not affected.
- On "Template Manager", set Beez3 as default front-end template, which makes easier to reproduce the problem. Edit: This does not only affect Beez3, but a lot of third party templates as well.
- On "Language Manager", set an RTL language as default front-end language, such as "Arabic", or "Hebrew". Edit: As per Brian's suggestion, it is not necessary to actually use Arabic language, you can just set
<rtl>1</rtl>in language/en-GB/en-GB.xml to get English behave RTL. - Browse a page on your site containing at least one "select" component, the Archived Articles view is perfect for this purpose.
index.php?option=com_content&view=archive - Open the "Select Month" dropdown. It is the rightmost. As soon as you choose an item, the most of the page elements disappear.
- Reload the page.
- Now open the pagination dropdown, which is the leftmost. Here the bug appears as soon as you open the dropdown. The problem is slightly different since it doesn't contain the search input-box.
When testing this patch, ensure to clear the cache of your browser and load the fixed css.
zero-24
- | Labels |
Added:
?
|
||
| Title |
|
||||||
joomla-cms-bot
- | Title |
|
||||||
| Labels |
Removed:
?
|
||
| Category | ⇒ | RTL |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
@demis-palma You are editing an external resource here, I think those changes should be applied to the template(s)
media/jui/css/chosen.css is bundled with Joomla.
Can you define "external"?
We have updated this file before and iirc we are not using the current
release but an unmaintained version due to bootstrap 2 compatibiity issues
so I see no reason that we do not apply this PR
On 5 June 2015 at 23:25, Demis Palma notifications@github.com wrote:
media/jui/css/chosen.css is bundled with Joomla.
Can you define "external"?—
Reply to this email directly or view it on GitHub
#7106 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@brianteeman thanks! So disregard my previous comment
From what I know, the original version from chosen bootstrap project, does not contain anything about RTL. The RTL implementation has been made by Joomla, but it is partial, therefore it causes problems.
Additional minor issues are still present, but currently I don't have the time to fix them.
I suggested to test beez tempalte because is bundled with Joomla, but I've noticed a lot of other third party tempaltes affected.
The bug is basically in this file, and therefore should be fixed in this file.
Yes that is correct - we need to fix it in our own version of chosen.css
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7106.
| Status | Pending | ⇒ | Ready to Commit |
Thanks - setting RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7106.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
wilsonge
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-11 16:23:20 |
| Closed_By | ⇒ | wilsonge |
johanjanssens
- | Labels |
Removed:
?
|
||
Note for testers it is not necessary to install arabic language just can just change the value of
Before
Issue confirmed
After
Issue resolved
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7106.