Feeling Lucky
?
[#7097] - Undefined $model passed to postDeleteHook
- Closed
- 3 Jun 2015
- Medium
- Build: staging
- # 7097
- Diff
- izharaazmi:patch-3
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Post delete hook called with $model not defined in context. Without calling delete method at all, the call to this hook is also pointless.
zero-24
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
jwaisner
- comment
- 3 Jun 2015
With PR applied items (articles, categories, users, usergroups, extensions, ect) delete successfully with no errors.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7097.
izharaazmi
- comment
- 3 Jun 2015
Please note that without this change, the undefined variable $model fatal error can be observed when cid[] parameter is not passed, i.e. when no items are selected for deletion.
This makes the test condition if (!is_array($cid) || count($cid) < 1) to pass and hence $model is never defined.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-03 06:11:34 |
| Closed_By | ⇒ | Bakual |
Bakual
- comment
- 3 Jun 2015
Thanks all!
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
Agree with the change as it indeed makes no sense.
To test make sure deleting any items still works with this change. It's probably used in almost all extensions.