[#7091] - Code review: JLanguageMultilang::isEnabled()
- Closed
- 1 Jun 2015
- Medium
- Build: staging
- # 7091
- Diff
- smz:JLanguageMultilang
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Description
By removing the dependency on JFactory::getApplication() we will be able to efficiently use this method in the application initialization phase (e.g. see #6309)
After all, at least one hit on the database will always be required, directly or indirectly, so I think it is just better to do it here and then rely on the static $enabled variable.
Test instructions
Multilingual and non-multilingual sites should behave as before.
zero-24
- | Category | ⇒ | Multilanguage |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
While testing this and an unpublished branch where I make modifications similar to @Hackwar #6309, I discovered that there are other issues in JApplicationSite::initialiseApp() that negate the usefulness of this patch.
Therefore, and for the time being, I'm closing this.
I might decide to reopen it if we get around the other issues (which I'll comment in #6309 as it is probably the best place where to talk about it)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-01 00:27:05 |
| Closed_By | ⇒ | smz |
@infograf768 JM, your opinion?