Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7087] - [#33854] New module display strip_tags instead of escape

? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
31 May 2015

See: #3766

This PR redo this PR: #3766 by @masters1333 with the suggestions by @Kubik-Rubik @Bakual and @roland-d and some codestyle

As an extension developer I sometimes include HTML in the description for better presentation in the administrator. When a new module is created the HTML is displayed in the new module screen which not only looks bad but does not provide the user a brief description of the module. I will create a pull request for the changes.

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33854

avatar zero-24 zero-24 - open - 31 May 2015
avatar zero-24 zero-24 - change - 31 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 31 May 2015
Status New ⇒ Pending
avatar zero-24 zero-24 - change - 31 May 2015
Title
…
New module display strip_tags instead of escape
[#33854] New module display strip_tags instead of escape
avatar zero-24 zero-24 - change - 31 May 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 31 May 2015
Category ⇒ Modules UI/UX
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2015
Title
…
[#33854] New module display strip_tags instead of escape
New module display strip_tags instead of escape
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2015
Title
…
New module display strip_tags instead of escape
[#33854] New module display strip_tags instead of escape
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2015
Title
…
New module display strip_tags instead of escape
[#33854] New module display strip_tags instead of escape
avatar roland-d
roland-d - comment - 9 Jun 2015

@test After downloading the example module from the joomlacode.org link, I installed the module and clicked on Extensions -> Modules. Click on New and see that the description runs out of the tooltip. After applying the patch, the tooltip is shown correctly.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7087.

avatar roland-d roland-d - test_item - 9 Jun 2015 - Tested successfully
avatar zero-24 zero-24 - change - 9 Jun 2015
Easy No ⇒ Yes
avatar jwaisner
jwaisner - comment - 11 Jun 2015

@test

After testing with module and patch applied tooltip is displayed correctly.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7087.

avatar jwaisner jwaisner - test_item - 11 Jun 2015 - Tested successfully
avatar zero-24 zero-24 - change - 11 Jun 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 11 Jun 2015

RTC Thanks :smile:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7087.

avatar zero-24 zero-24 - change - 11 Jun 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 11 Jun 2015
Labels Added: ?
avatar Bakual
Bakual - comment - 12 Jun 2015

Merged into staging with 0f69b1f.
Referenced wrong PR, sorry about that.

avatar Bakual Bakual - change - 12 Jun 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-06-12 13:54:53
Closed_By ⇒ Bakual
avatar Bakual Bakual - close - 12 Jun 2015
avatar Bakual Bakual - close - 12 Jun 2015
avatar zero-24 zero-24 - close - 12 Jun 2015
avatar Bakual Bakual - reference | 0f69b1f - 12 Jun 15
avatar zero-24
zero-24 - comment - 12 Jun 2015

@Bakual you only commit the first commit by @masters1333 but not mine. The other fixes are not included in the commit?

avatar zero-24 zero-24 - change - 12 Jun 2015
Milestone Added:
avatar Bakual
Bakual - comment - 12 Jun 2015

You mean 5907423 ?

avatar zero-24
zero-24 - comment - 12 Jun 2015

Yes thanks i have not seen it :smile:

avatar zero-24 zero-24 - head_ref_deleted - 12 Jun 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment