?
Success
-
Success
The Travis CI build passed
Details
User tests:
Successful:
Unsuccessful:
This PR restructures JErrorPage, the class that is used as our global Exception handler, to support PHP 7. Specific changes:
- Remove the typehinting for the render method
- Test internal to the method for an Exception (PHP 5) or BaseException (PHP 7)
- Add support to JDocumentError for the same
- Wrap jexit in a function_exists check so that it can be mocked in our PHPUnit suite
- Add unit tests to verify the PHP 7 behavior and the method's functionality when a non-Exception object is passed in
//cc @wilsonge
mbabker
-
open
-
30 May 2015
zero-24
-
change
-
30 May 2015
zero-24
-
change
-
30 May 2015
| Labels |
Added:
?
|
| Build |
3.5-dev |
⇒ |
staging |
joomla-cms-bot
-
change
-
30 May 2015
joomla-cms-bot
-
change
-
30 May 2015
zero-24
-
change
-
30 May 2015
| Category |
|
⇒ |
Administration
|
zero-24
-
change
-
30 May 2015
zero-24
-
change
-
30 May 2015
zero-24
-
change
-
30 May 2015
wilsonge
-
change
-
30 May 2015
| Status |
Pending |
⇒ |
Closed |
| Closed_Date |
0000-00-00 00:00:00 |
⇒ |
2015-05-30 16:27:43 |
| Closed_By |
|
⇒ |
wilsonge |
wilsonge
-
close
-
30 May 2015
wilsonge
-
merge
-
30 May 2015
wilsonge
-
close
-
30 May 2015
wilsonge
-
change
-
30 May 2015
Add a Comment
Login with GitHub to post a comment
@test OK
forced error on
/Users/dimitris/Documents/github_projects/joomla1/administrator/components/com_content/views/article/view.html.phpwith code:
JError::raiseError(500, implode("\n", array('1' => 'some error')));
return false;
result: