[#7062] - Adding option to show/hide phrases areas
- Closed
- 10 Jul 2015
- Medium
- Build: staging
- Easy Test
- # 7062
- Diff
- Devportobello:menuitemSearchFormOption
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Adding option to show / hide phrases areas without the need of overriding.
how to test
- Create menu item "Search Form or Search Results" and look "options"
- Go to frontend to inspect
- Apply patch, go to menu item created earlier, use the new "options" "Use Phrases areas"
- Go to frontend to inspect
Questioning
- Maybe this en-gb translation is bad.
- Did we need to separe the "phrases-box" and "ordering-box" with each option ?
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Labels |
Added:
?
?
|
||
| Category | ⇒ | Administration Front End Search |
| Status | New | ⇒ | Pending |
| Easy | No | ⇒ | Yes |
Phrases is definitely not the correct en-GB for this.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7062.
Phrases is just one of the three options that are enabled or disabled with this option.
To me these three radios are search options so I would suggest replaceing the word phrases with search options
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7062.
@test The patch works. I tested it by following the instructions above.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7062.
m-b-o
- 
@brianteeman so you suggest the following strings?
+COM_SEARCH_FIELD_SEARCH_PHRASES_DESC="Show the search options"
+COM_SEARCH_FIELD_SEARCH_PHRASES_LABEL="Use search options"
If yes @Devportobello can you implement it? So we can move this to RTC and merge into the core?
@zero-24 @Devportobello yes that would appear to make more sense
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7062.
Thanks @brianteeman so @Devportobello can implement the change? If done please give us a quick comment so we can move this to RTC 
Thanks!
@ this works fine
Translation modified.
Sorry please make the strngs
+COM_SEARCH_FIELD_SEARCH_PHRASES_DESC="Show the search options."
+COM_SEARCH_FIELD_SEARCH_PHRASES_LABEL="Use Search Options"
eg a Desc should have a fulltop at the end and a Label should be Capitalised
My bad, not noticed.
Done.
| Status | Pending | ⇒ | Ready to Commit |
Thanks @Devportobello, @brianteeman, @Preview, @jduerscheid, @m-b-o and @shre001 RTC'ing now 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7062.
| Labels |
Added:
?
|
||
Wouldn't it be better to change the language keywords (constants) names too?
Thank you @Devportobello! Merged with a623a90
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-10 10:52:40 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
This patch works.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7062.