Feeling Lucky
?
[#7058] - Regression: module edit pre-select position field does not check for existing module [fix: #7056]
- Closed
- 29 May 2015
- Medium
- Build: staging
- Easy Test
- # 7058
- Diff
- infograf768:module_regression
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
| Easy | No | ⇒ | Yes |
| Rel_Number | 0 | ⇒ | 7056 |
| Relation Type | ⇒ | Pull Request for |
| Rel_Number | 7056 | ⇒ | 0 |
| Relation Type | Pull Request for | ⇒ |
| Category | ⇒ | Administration |
Bakual
- comment
- 29 May 2015
Just wondering if a boolean check wouldn't be enough. So instead of
if ($data->id == null) use if (!$data->id).
It would also catch cases where the ID would be 0 or false, which is less strict than == null but serves the same purpose.
edit: It's actually doing exactly the same thing, due to the "loose" compare function (==). It will return true also for 0, false or an empty string. So there is no point in checking if it equals null, just use the boolean check (or !empty() if you prefer that).
joomla-cms-bot
- | Labels |
Added:
?
|
||
infograf768
- comment
- 29 May 2015
Used boolean. I guess it is RTC
zero-24
- | Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Bakual
- comment
- 29 May 2015
Looks fine, yes. Thanks!
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-29 18:38:19 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
@test ok
While posting discovered you beat me to it.
Tested creating and modifying a module both in empty and filtered list. All tests passed.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7058.