? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
23 May 2015

This PR makes improvements to the internals of JUri to make it easier to extend the class.

What's Changed?

References to self:: changed to static:: which improves support for class calls in extended classes, as well as the new JUri call changed to new static in getInstance() to allow the method to create an instance of a child object.

Testing Instructions

Just make sure things still work. If you're feeling brave, create a class extending JUri and make sure the behaviors with the static calls work as you would expect in the extended class.

avatar mbabker mbabker - open - 23 May 2015
avatar zero-24 zero-24 - change - 23 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 23 May 2015
Category Libraries
avatar zero-24 zero-24 - change - 23 May 2015
Status New Pending
Easy No Yes
avatar jwaisner
jwaisner - comment - 23 May 2015

@test

With Patch applied everything still functions as it should.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7021.

avatar jwaisner jwaisner - test_item - 23 May 2015 - Tested successfully
avatar fastslack
fastslack - comment - 24 May 2015

@test all seems to work fine after patch applied.

$ patch -p1 < 7021.patch 
patching file libraries/joomla/uri/uri.php
avatar zero-24 zero-24 - alter_testresult - 24 May 2015 - fastslack: Tested successfully
avatar zero-24 zero-24 - change - 24 May 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 24 May 2015

RTC Thanks :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7021.

avatar zero-24 zero-24 - change - 24 May 2015
Labels Added: ?
avatar zero-24 zero-24 - close - 24 May 2015
avatar wilsonge wilsonge - change - 24 May 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-05-24 17:03:39
Closed_By wilsonge
avatar wilsonge wilsonge - close - 24 May 2015
avatar wilsonge
wilsonge - comment - 24 May 2015

Merged - thanks guys!

avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment