[#7000] - RFC Batch modals comply with the new layout
- Closed
- 21 May 2015
- Medium
- Build: staging
- # 7000
- Diff
- dgt41:_rfc_batch_modals
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Batch modals are hardcoded. This is a proposal to make them more flexible/overridable. Right now it’s only for banners, but, if this gets some attention I will make it site wide.
So what’s in it?
Well batch modals have a tmpl/default_batch.php file that holds all the html code for the modal.
But since @smz and @phproberto made some nice changes in the bootstrap modal everything is more modular and everything is controlled from the respected layouts e.g. body, footer.
So this PR tries to break the hardcoded html code to 2 files tmpl/default_batch_body.php and tmpl/default_batch_footer.php
Now we have more control over the output (read this as getting ready for bs3)
| Title |
|
||||||
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
@test Tested successfully with both administrator templates. Batch feature still works properly!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7000.
#7000 Tested successfully with both administrator templates.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7000.
| Status | New | ⇒ | Ready to Commit |
@smz Sergio, if you test it, then please mark your result in the issue tracker as well (not only in a comment at GitHub).
@dgt41 Thank you for your contribution. I will merge it!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7000.
@Kubik-Rubik ... oops, forgot about it, sorry!
zero-24
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-21 14:33:22 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Added:
?
|
||
@Kubik-Rubik Victor, honestly I'd removed those width and height options before merging...
... but they do no harm: just ignored.
OK!
@smz @Kubik-Rubik will do it in #7003, thanks!
| Category | ⇒ | Administration |
| Labels |
Removed:
?
|
||
@test Success with current Firefox, IE11, current Chrome. and com_banners.
Batched several items succesfully. Could cancel, close etc.