[#6996] - Use correct element name for file extensions
- Fixed in Code Base
- 2 May 2016
- Medium
- Build: staging
- Easy Test
- # 6996
- Diff
- Chraneco:patch-5
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
When installing extensions of type file their element name (stored in the database) is not chosen correctly. Right now it uses the name of the extension which causes problems when trying to uninstall the extension again.
This pull request changes the installer so that it uses the same approach as for extensions of type library: The manifest file name is used for the element name.
Test Instructions
Before applying the patch, install the attached test file extension and uninstall it again. This will fail with the message Files Uninstall: Manifest file invalid or not found..
Then, apply the patch and do the same again. This time it will work.
EDIT: Unfortunately, it's not allowed to upload zip archives here, so I'm including the used manifest file here:
<?xml version="1.0" encoding="utf-8"?>
<extension type="file" version="3.0" method="upgrade">
<name>Nice Human Readable Extension 3</name>
<creationDate>2013/02/11</creationDate>
<author>JoomGallery::ProjectTeam</author>
<copyright>This component is released under the GNU/GPL License</copyright>
<authorEmail>test@test.com</authorEmail>
<authorUrl>http://test.net</authorUrl>
<version>1.0 BETA</version>
<description>Sample description</description>
<fileset>
<files target="components/com_content/views">
<file>test.php</file>
</files>
</fileset>
</extension>
I realized after I posted it was a different change, which is why the comment is deleted (at least on GitHub).
zero-24
- | Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
I have tested this item 
successfully on 96eb658
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6996.
| Easy | No | ⇒ | Yes |
I have tested this item successfully on 96eb658
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6996.
| Status | Pending | ⇒ | Ready to Commit |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels | |||
Committer please decide if this is a new feature or a bug fix - cant decide myself
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6996.
rdeutz
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-02 06:00:14 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
#6532 only changes the loading of language files. My example uses an extension without any language files.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6996.