[#6980] - Fix Feed-reader crashes site if source is not a newsfeed
- Closed
- 25 May 2015
- Medium
- Build: staging
- Easy Test
- # 6980
- Diff
- DannyBoyk:patch-1
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Change initial XMLReader loop to properly handle bad RSS feeds. Current loop will loop indefinitely until memory is exhausted.
http://issues.joomla.org/tracker/joomla-cms/5939
Steps to reproduce the issue
Ad a new "Module Feed Display" and set as Feed URL: http://www.google.com/robots.txt
Expected result
Message "Feed not available" in module position
Actual result
Site crash
Warning: XMLReader::read(): An Error Occurred while reading in \libraries\joomla\feed\factory.php on line 71
System information (as much as possible)
Joomla 3.3.6 / Apache 2.4.4 / PHP 5.5.3 / MySQL 5.6.11
Additional comments
We include a newsfeed which is sometimes down. In this case the feed-server returns a page with text/plain content - and our site crashes.
It makes no difference to include feed via module or via News Feed Manager.
zero-24
- | Title |
|
||||||
| Labels |
Added:
?
|
||||||
| Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Easy | No | ⇒ | Yes |
| Rel_Number | 0 | ⇒ | 5939 |
| Relation Type | ⇒ | Pull Request for |
Issue confirmed
PR resolves issue
Valid feeds are displayed and invalid feeds get the error message instead of the loop
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6980.
| Status | Pending | ⇒ | Ready to Commit |
Setting RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6980.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-25 00:20:37 |
| Closed_By | ⇒ | wilsonge |
Merged - thanks!
| Labels |
Removed:
?
|
||
@test ok!
I was able to reproduce the problem in Joomla 3.4.2dev with both
Feed Display Module and with Menu Item of type Single News Feed.
Adding http://www.google.com/robots.txt as URL Feed resulted with both in the error:
Fatal error: Maximum execution time of 30 seconds exceeded in /libraries/joomla/feed/factory.php on line 72
After the patch the error has been solved & you'll get a notification instead:
Feed Display Module
Menu Item of type Single News Feed
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6980.