[#6977] - Module Manager - pre-select fields on filters in Manager
- Closed
- 21 May 2015
- Medium
- Build: staging
- Easy Test
- # 6977
- Diff
- pe7er:module-edit-remember-fields
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR adds new pre-selection feature in the edit form of the Module Manager: The form fields Status, Position, Language and Access Level are pre-selected on basis of the [Search Tools] Set Filters in the Module Manager. Similar PR as #6966, #6973 & #6976.
Test instructions
Test in Module Manager: Modules if the selected [Search Tools] > **Filters (Status, Position, Language and Access Level) are pre-selected in the form when creating a New Module instance.
Module Manager: Modules
Back-end > Extensions > Module Manager > [Search Tools] > select (Status, Position, Language and Access Level).
Create new Module, e.g. Banner Module and check if the parameters on the left are "pre-selected".
Create new Module, e.g. Custom HTML Module and check if the parameters on the left are "pre-selected".
| Labels |
Added:
?
|
||
| Status | New | ⇒ | Pending |
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Administration UI/UX |
You added 1 condition which results in a warning because $this->getItem doesn't exists (no attribute getItem for $this). See the statement above which makes your if obsolete. There it is used as $this->getItem() which is a function instead of an attribute. The function works. Adding the code without the if also works, so just remove the if.
Thanks but lets wait for @pe7er to comment on #6977 (comment)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6977.
Obviously it is required to set error_reporting to 'maximum' for the warning to appear!
I've corrected the issue with if ($this->getItem == 0)
Thank you @sovainfo & @franz-wohlkoenig for testing & improvements!
Awesome PR. 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6977.
@JoshuaLewis can we count you as test and RTC than?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6977.
Yes, I have tested it with success. Placed in successful test vote above. Should be RTC now.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6977.
| Status | Pending | ⇒ | Ready to Commit |
Great RTC'ing now!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6977.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-21 11:46:11 |
| Closed_By | ⇒ | Kubik-Rubik |
Thanks for correcting! @infograf768
johanjanssens
- | Labels |
Removed:
?
|
||
Oops, missed the warning! There is no need for the condition, it is already there.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6977.