[#6961] - Fixes #6821. Load Bootstrap framework in icons layout for single article view
- Closed
- 22 May 2015
- Medium
- Build: staging
- # 6961
- Diff
- bertmert:patch-11
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Issue: #6821
- Go to Menu Manager and create a menu item Articles ยป Single Article. Select an article that doesn't load any plugins (pure text) to be sure that not a plugin will load Bootstrap.
- Set these 3 options to SHOW: Show Icons Show Print Icon Show Email Icon
- Go to frontend (Protostar) and open this menu item/article.
- Leave it open and go to backend Module Manager and deactivate ALL frontend modules. Just to be sure that not a module will load Bootstrap.
- Open Protostar > index.php for editing and remove line
JHtml::_('bootstrap.framework');
Bootstrap will also not be loaded by template now.
Go to frontend and reload page.
Should be something like this
Click button (cog). Doesn't expand. Nothing happens.
Apply patch, reload page and try again.
There are a few other views as well, which stopped working by removing bootstrap JS. Not sure if all of them get fixed by this change, but nevertheless -- good change for the future!
| Category | ⇒ | Front End |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
Looking good to me.
@BuddhiEash and @w00fz can we count your tests as successful? So we can set this PR RTC?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6961.
I tested and can confirm the PR fixes the issue.
| Status | Pending | ⇒ | Ready to Commit |
Thanks RTC'ing this now 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6961.
| Labels |
Added:
?
|
||
@zero24 yeah sure i think it's.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6961.
Thanks @BuddhiEash I have just alter your test
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6961.
so, bootstrap 3 templates will need to override icon.php i take it?
so, bootstrap 3 templates will need to override icon.php i take it?
This depends on how you or the template developer integrate BS3 in templates. It's possible to integrate your BS3 files as template overrides, too. Then the line
JHtml::_('bootstrap.framework');
loads your BS3 override and not BS2 from Joomla Core.
e.g. copy BS3-JS to
/templates/protostar/js/jui/bootstrap.min.js
and use
JHtml::_('bootstrap.framework');
in your template.
There are lots of framework files you can override like this (CSS, JS, Jquery, Mootools...)
Too many templates do not use this technique that could avoid many conflicts.
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-22 23:50:43 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
Hi i followed your steps.But although i removed the JHtml::_('bootstrap.framework'); line from Protostar > index.php file, still loads the icon.And it works without any issue.But want to say if i choose "Show Icons Show Print Icon Show Email Icon" to hide, then it's not showing.That means i think, it works fine.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6961.