? ? Success

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
14 May 2015

This PR changes the language file for the Smart Searchr (com_finder) so that the "Smart Search content plugin is not enabled. Changes to content will not update the Smart Search index if you do not enable this plugin." contains an hyperlink to the Plugin Manager.

Test instructions

In back-end > Components > Smart Search
If the Smart Search - Content Plugin is not enabled, it will display a message "Smart Search content plugin is not enabled. Changes to content will not update the Smart Search index if you do not enable this plugin."

screen shot 2015-05-14 at 10 14 32

This PR changes the language string

so that the warning message has a hyperlink to the Plugin Manager,
including a filter option for the name "Content - Smart Search".

screen shot 2015-05-14 at 10 14 32

Result of that hyperlink

If you click on the hyperlink you will be redirected to the Plugin Manager,
which filters the "Content - Smart Search" so you can easily enable it.

screen shot 2015-05-14 at 10 14 32

avatar pe7er pe7er - open - 14 May 2015
avatar pe7er pe7er - change - 14 May 2015
The description was changed
avatar hans2103
hans2103 - comment - 14 May 2015

even tiny steps like these will increase usability. Thank you @pe7er


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6948.

avatar hans2103 hans2103 - test_item - 14 May 2015 - Tested successfully
avatar hans2103
hans2103 - comment - 14 May 2015

@test succes

avatar zero-24
zero-24 - comment - 14 May 2015

@pe7er Same here would it be easier to use: id:441

As the ID will work every time on every language (as it is on all installs the same) or do we have reasons to not use the id?

avatar zero-24
zero-24 - comment - 14 May 2015

Please ignore my last comment. id is not a good way as we can not assume that the id is the same on all installations (see: #6947 (comment))

avatar sovainfo
sovainfo - comment - 14 May 2015

What makes you think assuming the labels are the same is better than assuming the id's are?
Sounds to me that using the id's is better, provided they are determined on execution time.
That requires the isEnabled to retrieve both enabled and id, introduce the getPluginid and replace that in the message with sprintf.

Then this works no matter the language used by the administrator in the backend!
It is also prepared for the time Joomla doesn't hard code these id's anymore!

avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2015
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2015
Labels Added: ?
avatar pe7er
pe7er - comment - 15 May 2015

I understand your concert @sovainfo. IMHO in this case labels are better than IDs provided that the reference to the Plugin Name is translated correctly.
I've added a comment for translators (thanks @infograf768 for this suggestion in a similar PR #6947 )

avatar zero-24 zero-24 - change - 15 May 2015
Category Administration UI/UX
avatar zero-24 zero-24 - change - 15 May 2015
Status New Pending
Easy No Yes
avatar zero-24 zero-24 - change - 15 May 2015
Category Administration UI/UX Administration Language & Strings UI/UX
avatar zero-24 zero-24 - change - 15 May 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 15 May 2015

@test also here successful. Thanks :smile: RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6948.

avatar zero-24 zero-24 - test_item - 15 May 2015 - Tested successfully
avatar zero-24 zero-24 - change - 15 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 15 May 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 16 May 2015
Milestone Added:
avatar wilsonge wilsonge - close - 16 May 2015
avatar wilsonge wilsonge - reference | 1b41e3a - 16 May 15
avatar wilsonge wilsonge - merge - 16 May 2015
avatar wilsonge wilsonge - close - 16 May 2015
avatar wilsonge wilsonge - change - 16 May 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-05-16 00:38:24
Closed_By wilsonge
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?
avatar pe7er pe7er - head_ref_deleted - 5 Nov 2015

Add a Comment

Login with GitHub to post a comment