? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
12 May 2015

As title says.
See: http://forum.joomla.org/viewtopic.php?f=711&t=887853

To test, add a "Create Article" menu item in each mainmenu of a multilanguage site.
Create a new article in different languages in front-end, it will propose as default in the dropdown the current language.

avatar infograf768 infograf768 - open - 12 May 2015
avatar zero-24 zero-24 - change - 12 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 12 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 12 May 2015
Category Multilanguage
avatar zero-24 zero-24 - change - 12 May 2015
Status New Pending
Easy No Yes
avatar infograf768
infograf768 - comment - 13 May 2015

I have tested here and it does not reset the language for an existing article.
The result of the patch is ONLY to present in the language dropdown the current language as already selected when creating a new article, a bit similar to what we get when we install a custom distribution and localise.xml <forceLang> is set, except evidently that in this case here, it does not change the language UI.
In case of validation error when editing an existing article, I guess the article is just not saved.
Please test.

avatar infograf768
infograf768 - comment - 13 May 2015

I nevertheless added the check you proposed above to make sure it only applies to a new article.

avatar infograf768
infograf768 - comment - 13 May 2015

In fact, the only validation issue I found is letting the new article title empty.
Therefore, I first changed the default language as proposed by this patch to another language, then let the title empty and clicked on Save. Got the error message and then checked the language: it was still set to the language I had chosen in the dropdown, it was NOT reset to the default one.

avatar joomdonation
joomdonation - comment - 13 May 2015

Hi JM

Looking at your original code again, I see that the code you proposed just set "default" value for language field, not set the value of the field, so my comments were invalid. You can remove that check, it is not needed.

avatar infograf768
infograf768 - comment - 13 May 2015

I still think your check is a good improvement. :+1:

One more tester :)

avatar anusiram
anusiram - comment - 13 May 2015

I tested it in my website. Now it is working as expected. Thank you very much for your valuable time

avatar infograf768
infograf768 - comment - 13 May 2015

Please RTC

avatar zero-24 zero-24 - alter_testresult - 13 May 2015 - joomdonation: Tested successfully
avatar zero-24 zero-24 - alter_testresult - 13 May 2015 - anusiram: Tested successfully
avatar zero-24 zero-24 - change - 13 May 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 13 May 2015

RTC based on testing by @anusiram and @joomdonation Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6925.

avatar zero-24 zero-24 - change - 13 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 13 May 2015
Labels Added: ?
avatar zero-24 zero-24 - close - 15 May 2015
avatar wilsonge wilsonge - change - 15 May 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-05-15 10:17:57
Closed_By wilsonge
avatar wilsonge wilsonge - close - 15 May 2015
avatar wilsonge wilsonge - reference | 512dc10 - 15 May 15
avatar wilsonge wilsonge - merge - 15 May 2015
avatar wilsonge wilsonge - close - 15 May 2015
avatar wilsonge wilsonge - change - 15 May 2015
Milestone Added:
avatar infograf768 infograf768 - head_ref_deleted - 15 May 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment