[#6917] - Layout for the field repeatable
- Closed
- 29 Oct 2015
- Medium
- Build: staging
- # 6917
- Diff
- Fedik:field-repeatable-layout
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Layout for the field repeatable, for j3.5
test
add repeatable field, example in some module options,
and make sure that after patch this field works as before patch
example field XML:
<field name="test" type="repeatable" icon="list" label="Test" description="Test descr"
maximum="5">
<fieldset hidden="true" repeat="true">
<field name="test_color" type="color" default="#eee"
label="color" description="test_color" />
<field name="test_list" type="list" default="1"
label="test_list" description="test_list" >
<option value="1">JYES</option>
<option value="0">JNO</option>
</field>
<field name="test_text" type="text"
label="test_text" description="test_text" />
<field name="test_textarea" type="textarea"
label="textarea" width="100" />
<field name="test_radio" default="0" type="radio"
label="test_radio" description="test_radio">
<option value="1">JYES</option>
<option value="0">JNO</option>
</field>
<field name="test_checkbox1" type="checkbox"
label="checkbox1" description="test_checkbox1" />
<field name="test_checkboxes" type="checkboxes"
label="checkboxes" description="test_checkboxes" >
<option value="a">A</option>
<option value="b">B</option>
<option value="c">C</option>
<option value="d">D</option>
</field>
</fieldset>
</field>p.s.: I need make this pull against 3.5-dev branch, or?
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Category | ⇒ | Layout Libraries |
| Title |
|
||||||
| Status | New | ⇒ | Pending | ||||
@test Success
Tested with custom module, see to install: https://github.com/Devportobello/joomla-attach-PR-6917
@test ok!
Can I make one more suggestion?
Since you use JHtml for the script changing line 83 to:
JHtml::_('script', 'system/repeatable.min.js', false, true, false, false, true);
and renaming repeatable.js to repeatable.min.js and repeatable-uncompressed.js to repeatable.js we 'll save some bytes over the wire!
repeatable-uncompressed.js has also to stay for B/C, I think (?)
I think better keep default behavior,
About repeatable.min.js: there all files that in media/system/js have format similar to repeatable.js and repeatable-uncompressed.js so here better stay as is .... I think it is another issue
@phproberto can you please check whether here is the right place for the layout file? currently 'libraries.joomla.form.fields.repeatable'
repeatable-uncompressed.js has also to stay for B/C, I think (?)
IIRC the uncompressed is used with debug enabled.
@Devportobello I think should be similar path as for the field file,
in case with calendar: the field in libraries/joomla/form/fields/calendar.php
so the layout need place in that way: libraries.joomla.form.fields.calendar
@phproberto know more, will wait his feedback
@zero-24 This needs a milestone 3.5
@Fedik @Devportobello Both your PRs as well as few more I did (#5654 #5655 #5871) actually have to wait for the new Layout renderer. There is #3231 and a comment that maybe https://github.com/joomla-projects/cms-naked/blob/master/libraries/cms/renderer/jlayout.php is what will be used is all we have right now. Bottom line, most probably this line will have to be adjusted accordingly to the outcome of the layout render decision!
tested like described with the testmodule - successfull
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6917.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Title |
|
||||||
RTC Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6917.
| Labels |
Added:
?
|
||
hm, yes and no 
I think PLT should decide ... whether we do the "layouts" for possible deprecated field or not 
you are right
I close here
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-29 07:31:26 |
| Closed_By | ⇒ | Fedik |
joomla-cms-bot
- | Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
@Fedik How can we test this? Can you add some test instructions?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6917.