? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
9 May 2015

Testing instructions using staging:
Create an article with Access set to Registered.
Toggle editor and paste this in the text area (as it seems the Read More button is broken here, separate bug)

<p>some text before read more</p>
<hr id="system-readmore" />
<p>some other text</p>

Then create a single article menu item set to Public Access to display the single article above.
Make sure that Options->Show Unauthorised Links is set to Yes.

In Frontend, click on the menu item.
=> The article will display with a "Register to Read More" button.
Click on the button
=> the login fields are displayed
Login
=> the redirect is to the Profile edit and NOT to the registered article.

Logout.
Patch.
Redo the Frontend steps
Now the registered article displays in full.

The code used here is similar to the one used in category blogs or featured.

avatar infograf768 infograf768 - open - 9 May 2015
avatar zero-24 zero-24 - change - 9 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 9 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 9 May 2015
Status New Pending
avatar zero-24 zero-24 - change - 9 May 2015
Category Front End Router / SEF
avatar zero-24 zero-24 - change - 9 May 2015
Easy No Yes
avatar Dylis
Dylis - comment - 9 May 2015

@test I tested the patch according instructions, it's working, the readmore link display login form and then full article after login.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6908.

avatar Dylis Dylis - test_item - 9 May 2015 - Tested successfully
avatar Harmageddon
Harmageddon - comment - 9 May 2015

Can confirm the undesired behavior before the patch. The proposed patch solves the problem. Code seems good, too. Setting to RTC, as we have two successful tests.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6908.

avatar Harmageddon Harmageddon - test_item - 9 May 2015 - Tested successfully
avatar Harmageddon Harmageddon - change - 9 May 2015
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 9 May 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 9 May 2015
Labels Added: ?
avatar Kubik-Rubik
Kubik-Rubik - comment - 9 May 2015

Hello @infograf768, thank you for your PR. To keep our consistent approach in template files, please add opening and closing PHP tags to each line. I will remove the RTC label in the meantime.

avatar Kubik-Rubik Kubik-Rubik - change - 9 May 2015
Status Ready to Commit Pending
avatar Kubik-Rubik Kubik-Rubik - change - 9 May 2015
Labels Removed: ?
avatar Kubik-Rubik Kubik-Rubik - change - 9 May 2015
Labels Removed: ?
avatar infograf768
infograf768 - comment - 10 May 2015

@Kubik-Rubik
I have not done that as the same code for blog and featured is coded this way (without opening and closing php).
Shall I still do that and at the same time correct featured and blog?

avatar infograf768
infograf768 - comment - 10 May 2015

Plus the fact that we have many other lines in the same file which do not follow this rule.

avatar infograf768
infograf768 - comment - 10 May 2015

Anyway changed for the lines concerned in this PR.

avatar zero-24
zero-24 - comment - 10 May 2015

Thanks @infograf768 Adding the RTC label back :smile:

avatar zero-24 zero-24 - change - 10 May 2015
Status Pending Ready to Commit
avatar zero-24 zero-24 - change - 10 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 10 May 2015
Labels Added: ?
avatar zero-24 zero-24 - close - 10 May 2015
avatar roland-d roland-d - change - 10 May 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-05-10 12:28:30
Closed_By roland-d
avatar roland-d roland-d - close - 10 May 2015
avatar roland-d roland-d - close - 10 May 2015
avatar zero-24 zero-24 - change - 10 May 2015
Milestone Added:
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment