User tests: Successful: Unsuccessful:
Testing instructions using staging:
Create an article with Access set to Registered.
Toggle editor and paste this in the text area (as it seems the Read More button is broken here, separate bug)
<p>some text before read more</p>
<hr id="system-readmore" />
<p>some other text</p>
Then create a single article menu item set to Public Access to display the single article above.
Make sure that Options->Show Unauthorised Links is set to Yes.
In Frontend, click on the menu item.
=> The article will display with a "Register to Read More" button.
Click on the button
=> the login fields are displayed
Login
=> the redirect is to the Profile edit and NOT to the registered article.
Logout.
Patch.
Redo the Frontend steps
Now the registered article displays in full.
The code used here is similar to the one used in category blogs or featured.
Labels |
Added:
?
|
Labels |
Added:
?
|
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Router / SEF |
Easy | No | ⇒ | Yes |
Can confirm the undesired behavior before the patch. The proposed patch solves the problem. Code seems good, too. Setting to RTC, as we have two successful tests.
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
Labels |
Added:
?
|
Hello @infograf768, thank you for your PR. To keep our consistent approach in template files, please add opening and closing PHP tags to each line. I will remove the RTC label in the meantime.
Status | Ready to Commit | ⇒ | Pending |
Labels |
Removed:
?
|
Labels |
Removed:
?
|
@Kubik-Rubik
I have not done that as the same code for blog and featured is coded this way (without opening and closing php).
Shall I still do that and at the same time correct featured and blog?
Plus the fact that we have many other lines in the same file which do not follow this rule.
Anyway changed for the lines concerned in this PR.
Thanks @infograf768 Adding the RTC label back
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-10 12:28:30 |
Closed_By | ⇒ | roland-d |
Milestone |
Added: |
Labels |
Removed:
?
|
@test I tested the patch according instructions, it's working, the readmore link display login form and then full article after login.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6908.