[#6893] - Clean up the published method.
- Closed
- 10 May 2015
- Medium
- Build: staging
- # 6893
- Diff
- roland-d:cleanup-content
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Goal
The goal of this pull request is to clean up some code that I found is duplicate and could be improved after checking #3189. This completely removes the publish() override for the JTableContent class as it is obsolete with the update.
How to test
- Go to the article manager: administrator/index.php?option=com_content&view=articles
- Unpublish an article and check that it works
- Publish an article and check that it works
- Apply this pull request
- Unpublish an article and check that it works
- Publish an article and check that it works
| Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
@infograf768 For good reason Travis wasn't happy, there was an issue indeed but is solved now. Travis is happy 
@test success i published and unpublished an article successfully
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6893.
@test - Success. Patch tested with article set both to registred and public display.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6893.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6893.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-10 00:20:46 |
| Closed_By | ⇒ | wilsonge |
Merged - Thanks!
| Milestone |
Added: |
||
Hmm. This PR is still having issue which I pointed above. I don't think it is not good to be merged yet :(.
@joomdonation Correct, I will create a new PR for that.
| Labels |
Removed:
?
|
||
Looks like Travis is not happy.