This PR is fine by me :)

not sure if it matter or not but i tried to run a unit test:

Time: 45.27 seconds, Memory: 184.25Mb


FAILURES!
Tests: 5704, Assertions: 10160, Failures: 13, Errors: 216, Incomplete: 1, Skipped: 69.

Process finished with exit code 2

looks like it is ome database thing incorrect i and trying to figure it out

Do you get Unit Test failures for the code you touched, or any code which uses the code you touched?

only thing i toutch other than than this pt, is to run composer, copy "phpunit.xml" and uncomment settings for DB inside. and run it. (i have db created, and user), still looking in to what i do wrong.

I don't see and code for auth plugin?

You should start with looking at the PHPUnit output. See which tests are failing. Track them down and see if these are failures that have to do with your code or not.

I fixed the incorrect UT config setup

Time: 54.6 seconds, Memory: 180.00Mb


FAILURES!
Tests: 5704, Assertions: 10212, Failures: 1, Incomplete: 1, Skipped: 264.

Process finished with exit code 1

Failed asserting that false matches expected '�bc �de EUR100'.
Expected :�bc �de EUR100
Actual   :false
 <Click to see difference>

 /home/fanno/workspace/phpstorm/fanno/joomla-cms/tests/unit/suites/libraries/joomla/string/JStringTest.php:815
 phar:///home/fanno/workspace/phpunit/phpunit-lts.phar/phpunit/TextUI/Command.php:176

should now be gtg.

Yes, indeed. It looks that the only failing test is one which depends on unicode string manipulation that has nothing to do with your PR.

I had enabled all databases but only have system configured for mysql, and the utuser premissions was incorrect =) been a long time since i ran this ut last

Merged on review