?
avatar okonomiyaki3000
okonomiyaki3000
24 Jan 2013

First of all, some stuff everybody knows:

  • The content column of the #__modules table is only used by mod_custom and can only be used by com_custom.
  • The admin component com_modules gives special treatment to mod_custom.
  • A module developer has no way to get a field on the module edit page which will be stored in the content column because com_modules gives this field to mod_custom and only mod_custom.

I think this is a problem because some developer might like to make a different module type that uses the content field. Also, as a matter of code quality, I believe it would be nice if com_modules didn't need to know that mod_custom exists at all. It should have some other criteria (probably based on a value from the module's xml file) to tell it whether or not to show an editor and store a value in the content column.

Making this change is trivial, it requires only an addition to the mod_custom xml file and a minor change to com_modules in one or two files. But I'm concerned about changing the xml file. There doesn't seem to be a dtd for this file so there's maybe no issue with modifying it in some way but I'd like to know if anyone has any thoughts on it before I proceed.

avatar okonomiyaki3000 okonomiyaki3000 - open - 24 Jan 2013
avatar zero-24 zero-24 - close - 5 May 2013
avatar nicksavov nicksavov - close - 5 May 2013
avatar nicksavov
nicksavov - comment - 5 May 2013

Thanks for posting this, Elijah! Can you send a pull request? If you need to learn how, check out this tutorial:
http://docs.joomla.org/Git_for_Coders

I also created a tracker item for this issue:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30850

You can receive notifications from it by signing in, going to the item, and clicking "Monitor Item" in the left column.

While we’re transitioning to a new integrated tracker, the JoomlaCode tracker is where we do most of Joomla's bug fixing. You can find out more about the process at:
http://docs.joomla.org/Filing_bugs_and_issues

I'm going to close this item, since we have the above JoomlaCode Tracker Item. If and when you submit a pull request, please reference the JoomlaCode Tracker Item URL:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30850

Let me know if you have any questions and I'll be glad to answer. Thanks again, Elijah!

avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: ?
Removed: ?
Build staging

Add a Comment

Login with GitHub to post a comment