[#6878] - Update cacert.pem to latest version
- Closed
- 1 May 2015
- Medium
- Build: staging
- # 6878
- Diff
- nicksavov:patch-3
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
| Labels |
Added:
?
|
||
@nicksavov do we have any chance to test the change?
| Category | ⇒ | External Library Libraries |
| Status | New | ⇒ | Pending |
Thanks Tobias!
I don't think testing is needed for this one and it can just be merged. It's just syncing the file with the official one at http://curl.haxx.se/ca/cacert.pem
Examples of two previous PRs for it that were merged without testing:
#4296
#3634
hehe i have ask the same some time bevor in a previous PR 
So I'm going to mark it RTC so a Maintainer can review and merge. Thanks
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-01 17:37:21 |
| Closed_By | ⇒ | wilsonge |
Thanks Nick!
Shouldn't this be something that is always done as part of the release
procedure. Otherwise it will always be out of date and we will have
multiple pull requests to update the cert before we ever get to a release.
On 1 May 2015 6:37 pm, "George Wilson" notifications@github.com wrote:
Thanks Nick!
—
Reply to this email directly or view it on GitHub
#6878 (comment).
+1
I'd rather see PRs to update it as appropriate in the off chance a change in the cacert manages to break a site's ability to connect to a resource because of certificate verification.
| Labels |
Removed:
?
|
||
Framework PR:
joomla-framework/http#16