? Success
Pull Request for # 6855

User tests: Successful: Unsuccessful:

avatar bertmert
bertmert
30 Apr 2015

See discussion here
#6855

Test:

  • Use template Protostar.
  • Create new module mod_search.
  • Enter 10 in field Box Width (size).
  • See front end: Size attribute of search input is ignored because Bootstrap CSS sets a fixed width that overrides size attribute.

  • Apply patch.

  • See front end: Search INPUT has width (size) 10 now.

  • Leave field Box Width empty in module settings.
  • CSS width rules now.
avatar bertmert bertmert - open - 30 Apr 2015
avatar bertmert bertmert - change - 30 Apr 2015
Title
Fixes #4879. mod_search. Option *Box Width* (size) ignored if INPUT width also set by CSS.
Fixes #6855. mod_search. Option *Box Width* (size) ignored if INPUT width also set by CSS.
avatar bertmert bertmert - change - 30 Apr 2015
Title
Fixes #4879. mod_search. Option *Box Width* (size) ignored if INPUT width also set by CSS.
Fixes #6855. mod_search. Option *Box Width* (size) ignored if INPUT width also set by CSS.
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2015
Labels Added: ?
avatar Webdongle
Webdongle - comment - 30 Apr 2015

@test

Applied patch
Changed size of search box in the search module edit screen
Viewed from front end No Avail
No change in the size of the search box

Does Not work


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6873.

avatar Webdongle Webdongle - test_item - 30 Apr 2015 - Tested unsuccessfully
avatar zero-24 zero-24 - change - 30 Apr 2015
Category Front End Search
avatar zero-24 zero-24 - change - 30 Apr 2015
Status New Pending
avatar bertmert
bertmert - comment - 1 May 2015

@Webdongle Cannot confirm.
Installed a fresh Joomla 3.4.1 right now and got these results:

Before patch

mod_search

After patch

mod_search2

Test with Firebug after patch

mod_search3

How did you apply the patch? Did you replace all files (3)?

Give com_patchtester a try: https://github.com/joomla-extensions/patchtester/releases

avatar infograf768
infograf768 - comment - 1 May 2015

This works here.

avatar zero-24 zero-24 - alter_testresult - 1 May 2015 - infograf768: Tested successfully
avatar Webdongle
Webdongle - comment - 1 May 2015

Tested again this time success ... the width of the box changed

SUCCESS

The search box in the components area of the results page does not alter but the search box in the module position works as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6873.

avatar Webdongle Webdongle - test_item - 1 May 2015 - Tested successfully
avatar zero-24 zero-24 - change - 1 May 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 1 May 2015

Great so RTC'ing here :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6873.

avatar zero-24 zero-24 - change - 1 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 1 May 2015
Labels Added: ?
avatar bertmert
bertmert - comment - 1 May 2015

@Webdongle

The search box in the components area of the results page does not alter

Component has no setting Box Width.
size=30 is hard coded there.

So, this argument does not convince me concerning component com_search
#6855 (comment)

avatar Webdongle
Webdongle - comment - 1 May 2015

On 01/05/2015 15:43, bertmert wrote:

@Webdongle https://github.com/Webdongle

The search box in the components area of the results page does not
alter

Component has no setting /Box Width/.
size=30 is hard coded there.

So, this argument does not convince me concerning component com_search

@bertmert

It was not an argument to convince you of anything ... it was an
observation. Your quote of me was out of context. The full quote "/The
search box in the components area of the results page does not alter but
the search box in the module position works as expected/". There are two
clauses in that sentence with the word 'but' as a conjunction
http://www.bbc.co.uk/worldservice/learningenglish/grammar/learnit/learnitv161.shtml
. That implies the first clause has no direct affect on the second. So
please do not twist my words by quoting part of the sentence.

To be clear (just in case English is not you first language) ...
After my first test failed and others tested successfully ... I realised
that my test must have been inaccurate so I tested again. That test was
successful but I noticed the search box in the result page did not
change. To save time typing several sentences I used one sentence with
two clauses. I should have realised that my correct use of English
Grammar would have been misinterpreted. And I should have put my
observation of the results page in a separate paragraph explaining that
I am not as thick as you think am because I realise they are two
different things.

avatar roland-d roland-d - change - 2 May 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-05-02 18:05:11
Closed_By roland-d
avatar roland-d roland-d - close - 2 May 2015
avatar zero-24 zero-24 - close - 2 May 2015
avatar roland-d roland-d - close - 2 May 2015
avatar roland-d roland-d - change - 2 May 2015
Milestone Added:
avatar roland-d roland-d - change - 2 May 2015
Rel_Number 0 6855
Relation Type Pull Request for
avatar bertmert
bertmert - comment - 6 May 2015

@Webdongle

To be clear (just in case you're not able to understand Github principles)

This PR has a title. It's referenced to an issue plus discussion, that also has a title. Read it.

If you have additional problems with com_search, that need a different way to solve it because com_search has no option Box Width, do not use issues concerning mod_search because you're comment will be ignored. If it would be a smiliar solution I would have created an additional PR because mbabker's comment would have convinced me.
Thus YOU have to open a new issue, provide a test instruction, define a feature request, describe your expected result, whatever ... instead of telling me bla bla... (Be aware that I won't read it because I'm not a native-speaking English teacher and will not understand it.)

avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment