User tests: Successful: Unsuccessful:
See discussion here
#6855
Test:
See front end: Size attribute of search input is ignored because Bootstrap CSS sets a fixed width that overrides size attribute.
Apply patch.
See front end: Search INPUT has width (size) 10 now.
Title |
|
Title |
|
Labels |
Added:
?
|
Labels |
Added:
?
|
Category | ⇒ | Front End Search |
Status | New | ⇒ | Pending |
@Webdongle Cannot confirm.
Installed a fresh Joomla 3.4.1 right now and got these results:
Before patch
After patch
Test with Firebug after patch
How did you apply the patch? Did you replace all files (3)?
Give com_patchtester a try: https://github.com/joomla-extensions/patchtester/releases
This works here.
Tested again this time success ... the width of the box changed
SUCCESS
The search box in the components area of the results page does not alter but the search box in the module position works as expected.
Status | Pending | ⇒ | Ready to Commit |
Great so RTC'ing here
Labels |
Added:
?
|
Labels |
Added:
?
|
The search box in the components area of the results page does not alter
Component has no setting Box Width.
size=30 is hard coded there.
So, this argument does not convince me concerning component com_search
#6855 (comment)
On 01/05/2015 15:43, bertmert wrote:
@Webdongle https://github.com/Webdongle
The search box in the components area of the results page does not alter
Component has no setting /Box Width/.
size=30 is hard coded there.So, this argument does not convince me concerning component com_search
It was not an argument to convince you of anything ... it was an
observation. Your quote of me was out of context. The full quote "/The
search box in the components area of the results page does not alter but
the search box in the module position works as expected/". There are two
clauses in that sentence with the word 'but' as a conjunction
http://www.bbc.co.uk/worldservice/learningenglish/grammar/learnit/learnitv161.shtml
. That implies the first clause has no direct affect on the second. So
please do not twist my words by quoting part of the sentence.
To be clear (just in case English is not you first language) ...
After my first test failed and others tested successfully ... I realised
that my test must have been inaccurate so I tested again. That test was
successful but I noticed the search box in the result page did not
change. To save time typing several sentences I used one sentence with
two clauses. I should have realised that my correct use of English
Grammar would have been misinterpreted. And I should have put my
observation of the results page in a separate paragraph explaining that
I am not as thick as you think am because I realise they are two
different things.
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-02 18:05:11 |
Closed_By | ⇒ | roland-d |
Milestone |
Added: |
Rel_Number | 0 | ⇒ | 6855 |
Relation Type | ⇒ | Pull Request for |
To be clear (just in case you're not able to understand Github principles)
This PR has a title. It's referenced to an issue plus discussion, that also has a title. Read it.
If you have additional problems with com_search, that need a different way to solve it because com_search has no option Box Width, do not use issues concerning mod_search because you're comment will be ignored. If it would be a smiliar solution I would have created an additional PR because mbabker's comment would have convinced me.
Thus YOU have to open a new issue, provide a test instruction, define a feature request, describe your expected result, whatever ... instead of telling me bla bla... (Be aware that I won't read it because I'm not a native-speaking English teacher and will not understand it.)
Labels |
Removed:
?
|
@test
Applied patch
Changed size of search box in the search module edit screen
Viewed from front end No Avail
No change in the size of the search box
Does Not work
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6873.