? Success
Not before # 5729

User tests: Successful: Unsuccessful:

avatar OctavianC
OctavianC
30 Apr 2015

Issue

During the installation of any extension, the installer script can display its own message, including HTML content (which most extensions do). Since 3.4.0 the contents of this message is forcefully bold. I believe that #5729 introduced this.

Steps to replicate it

Install any extension that provides a HTML message upon installation. You'll notice that the whole message is wrapped in <strong> tags.

Proposed fix

It's simple: remove the <strong> tags that are wrapping the message supplied by the installation script. I have left the <strong> tags that show up when displaying the XML <description> tag since most people don't use HTML in there so it shouldn't be a problem. The non-bootstrapped version (before the PR) did display the description in <th> tags and the message in <td> tags, so I'm following what was already in place.

Before

bold-forced

After

no-bold

avatar OctavianC OctavianC - open - 30 Apr 2015
avatar zero-24
zero-24 - comment - 30 Apr 2015

@OctavianC do you think we need also remove the <strong> on line 19 in the same file?

avatar zero-24 zero-24 - change - 30 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 30 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 30 Apr 2015
Category Installation Templates (admin) UI/UX
avatar zero-24 zero-24 - change - 30 Apr 2015
Title
Remove <strong> tag when displaying extension installer message.
Remove tag when displaying extension installer message.
Status New Pending
Easy No Yes
avatar zero-24 zero-24 - change - 30 Apr 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 30 Apr 2015
Labels Removed: ?
avatar OctavianC
OctavianC - comment - 30 Apr 2015

As I said in my original post, <th> was in place before the change was introduced, so the <description> tag was indeed bold. I think we should keep it this way for now.

avatar zero-24
zero-24 - comment - 30 Apr 2015

ok Thanks :smile:

avatar zero-24 zero-24 - change - 30 Apr 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 7 May 2015

@test successful. Thanks for fixing it. One more tester :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6870.

avatar zero-24 zero-24 - test_item - 7 May 2015 - Tested successfully
avatar gunjanpatel
gunjanpatel - comment - 9 May 2015

Tested successfully. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6870.

avatar gunjanpatel gunjanpatel - test_item - 9 May 2015 - Tested successfully
avatar gunjanpatel gunjanpatel - change - 9 May 2015
Title
Remove <strong> tag when displaying extension installer message.
Remove tag when displaying extension installer message.
Status Pending Ready to Commit
avatar gunjanpatel gunjanpatel - change - 9 May 2015
Rel_Number 0 5729
Relation Type Not before
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2015
Title
Remove <strong> tag when displaying extension installer message.
Remove tag when displaying extension installer message.
avatar gunjanpatel gunjanpatel - change - 9 May 2015
Title
Remove tag when displaying extension installer message.
Remove  tag when displaying extension installer message.
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2015
Title
Remove tag when displaying extension installer message.
Remove <strong> tag when displaying extension installer message.
avatar zero-24 zero-24 - change - 9 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 9 May 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 9 May 2015

RTC :smile:

avatar Kubik-Rubik Kubik-Rubik - reference | 11dd659 - 9 May 15
avatar Kubik-Rubik Kubik-Rubik - close - 9 May 2015
avatar zero-24 zero-24 - close - 9 May 2015
avatar Kubik-Rubik
Kubik-Rubik - comment - 9 May 2015

Thank you @OctavianC for the contribution.

avatar Kubik-Rubik Kubik-Rubik - change - 9 May 2015
Title
Remove <strong> tag when displaying extension installer message.
Remove  tag when displaying extension installer message.
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-05-09 13:59:29
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 9 May 2015
avatar zero-24 zero-24 - change - 9 May 2015
Milestone Added:
avatar zero-24 zero-24 - change - 14 Oct 2015
Title
Remove <strong> tag when displaying extension installer message.
Remove  tag when displaying extension installer message.
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment