User tests: Successful: Unsuccessful:
@houbahoubi described the issue here
#6287 (comment)
and referenced
http://forum.joomla.org/viewtopic.php?f=706&t=884342#p3296536
Test instructions:
Set Show Unauthorised Links to YES > Save and Close.
Create a category and add 1, 2, 3 articles WITH READ MORE marker in editor text.
Go to Extensions > Module Manager
See frontend
Go to backend and set Acces of one or more of these articles to Registered.
See frontend
Landing page (return page) is profile editing page instead of article view.
Logout!!
Apply patch.
Click Register to Read More > Login.
@bertmert it looks like a global travis issue. as we have a similiar here: https://travis-ci.org/joomla/joomla-cms/jobs/60622434
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Modules |
Hello
Thanks a lot for your help! So I works fine for me, with the modified code for the helper.php file I am now redirected to the article !
But just a little think again I am redirected to the article but on the default homepage menu not in the real place of my article so in the good menu.
After login the link is : ..../index.php?option=com_content&view=article&id=11:actualite-3-avec-acces-securise&catid=11&Itemid=138
Or the real place of the article is : .../index.php?option=com_content&view=article&id=11:actualite-3-avec-acces-securise&catid=11&Itemid=138
As you see it's just the & instead of & that cause the problem ? Have you an idea ?
Thanks
@houbahoubi Thanks for testing.
I made my tests with SEF enabled in Joomla. I was redirected to the correct menu.
Because I don't understand: Could you please surround the URLs in your comment with three backticks like this.
to get output like this
&blah=blubb&blahh=blabb
@houbahoubi Please test again.
Yes, you're right but I don't understand why this happens.
index.php?option=com_content&view=article&id=8:beginners&catid=19&Itemid=260
redirects correctly. But not
index.php?option=com_content&view=article&id=8:beginners&catid=19&Itemid=260
Maybe somebody can help us why we need this additional line that I've added now to the patch when SEF is disabled::
$returnURL = str_replace('&', '&', $returnURL);
Hello
@bertmert Many thanks for your quick help
Yes exactly untill now I test my website in non-sef mode. I test with sef mode I have not the problem exactly like you.
I have modified the code with your updated code, and now it works fine for me with non-sef mode too.
Status | Pending | ⇒ | Ready to Commit |
Thanks so i'm RTC'ing here
Labels |
Added:
?
|
Hmm, it looks likes the &
issue is not only existing here —when sef off— but in every layout using this.
Blog, featured, single article.
@bertmert To avoid the mentioned problem, you have to set the second argument in JRoute::_ to false. Could you please update your PR to:
$item->link = new JUri(JRoute::_('index.php?option=com_users&view=login', false));
$item->link->setVar('return', base64_encode(JRoute::_(ContentHelperRoute::getArticleRoute($item->slug, $item->catid, $item->language), false)));
$item->linkText = JText::_('MOD_ARTICLES_NEWS_READMORE_REGISTER');
(This is the complete else-statement.)
Thank you in advance! After you've updated the PR, I will merge it.
I guess we should also do that in the other layouts I mentioned above.
@infograf768 Yes, we should do it there too.
Labels |
Removed:
?
|
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Needs Review |
Status | Needs Review | ⇒ | Pending |
Labels |
Removed:
?
|
@Kubik-Rubik
Code changed (#6864 (comment)) and tested, SEF and non-SEF
Labels |
Added:
?
|
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-22 10:41:21 |
Closed_By | ⇒ | Kubik-Rubik |
@infograf768
Yes, I can.
Thanks, please do not forget beez3. ;)
Labels |
Removed:
?
|
Could someone please have a look at Travis error. I don't understand: