Feeling Lucky
?
[#6847] - Fix PHP Notice in Smart Search adapter (#6842)
- Closed
- 23 May 2015
- Medium
- Build: staging
- # 6847
- Diff
- chrisdavenport:patch-3
- Success The Travis CI build passed Details
Pull Request for
# 6842
User tests: Successful: Unsuccessful:
Fix for #6842.
If a menu item exists but there is no page_title parameter set, then indexing will throw a PHP notice. This PR suppresses the notice by first checking that the parameter exists.
brianteeman
- | Rel_Number | ⇒ | 6842 | |
| Relation Type | ⇒ | Pull Request for |
zero-24
- | Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
| Labels |
Added:
?
|
||
| Category | ⇒ | CLI Search |
| Status | New | ⇒ | Pending |
chrisdavenport
- comment
- 9 May 2015
I don't know how you would get to the point where you have a menu item without the page_title parameter being set, so the easiest way to test this PR is, as you suggest, to use phpMyAdmin to manually remove it from a menu item that points to an article.
To make it super easy, I use https://www.jsoneditoronline.org/ to edit the json-encoded parameters.
wilsonge
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-23 01:08:09 |
| Closed_By | ⇒ | wilsonge |
@chrisdavenport
Could you please add a test instructions so that others can reproduce this issue?
This issue is somewhat difficult to reproduce:
when you create a new menu item,the page_title is added to parameters:
"page_title":""
Do you have to remove that parameter via phpMyAdmin to trigger the error?
Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6847.