? Success

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
25 Apr 2015

The JToolbarHelper::back() button currently does not display an icon, because it expects the class to be .icon-back, but it would have to be .icon-chevron-left. Theoretically, this could be solved with .icon-back:before:extend(.icon-chevron-left:before), but since our LESS compiler version in Joomla is ancient, we gotta basically hardcode this in here.

How to test? Add JToolbarHelper::back() somewhere in a view.html.php file in the backend. See that it has no icon. Apply the patch and see that it has an arrow.

avatar Hackwar Hackwar - open - 25 Apr 2015
avatar wilsonge
wilsonge - comment - 28 Apr 2015

Would it not be easier rather than adding a new icon just changing the icon (2nd param here https://github.com/joomla/joomla-cms/blob/staging/administrator/includes/toolbar.php#L153) to be icon-chevron-left?

avatar Hackwar
Hackwar - comment - 28 Apr 2015

That means that all those, that use the back class would still be broken. It wouldn't really be B/C.

avatar zero-24 zero-24 - change - 29 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 29 Apr 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 29 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 29 Apr 2015
Category Templates (admin)
avatar zero-24 zero-24 - change - 29 Apr 2015
Status New Pending
Easy No Yes
avatar OctavianC
OctavianC - comment - 5 May 2015

result
Works!

avatar zero-24 zero-24 - alter_testresult - 5 May 2015 - OctavianC: Tested successfully
avatar gunjanpatel
gunjanpatel - comment - 9 May 2015

I can confirm that this patch is working as described. I can see Back button icon after applying patch.
Also the alternative solution(which doesn't need this patch) works too.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6844.

avatar gunjanpatel gunjanpatel - test_item - 9 May 2015 - Tested successfully
avatar gunjanpatel gunjanpatel - change - 9 May 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 9 May 2015

RTC

avatar zero-24 zero-24 - change - 9 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 9 May 2015
Labels Added: ?
avatar mbabker mbabker - close - 9 May 2015
avatar mbabker mbabker - reference | cfbf129 - 9 May 15
avatar mbabker mbabker - merge - 9 May 2015
avatar mbabker mbabker - close - 9 May 2015
avatar zero-24 zero-24 - close - 9 May 2015
avatar mbabker mbabker - change - 9 May 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-05-09 15:31:29
Closed_By mbabker
avatar zero-24 zero-24 - change - 9 May 2015
Milestone Added:
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?
avatar Hackwar Hackwar - head_ref_deleted - 6 Jan 2016

Add a Comment

Login with GitHub to post a comment