[#6835] - Template discover install does not load language files
- Closed
- 25 Apr 2015
- Medium
- Build: staging
- # 6835
- Diff
- mahagr:template-discover-bug
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
When using discover install, path to the template is wrong when loading the language.
Old code pointed to site/templates/{$template} or ADMINISTRATOR/templates/{$template} where it should point to the real directory, either in administration or site.
This pull request will fix the lookup path to point to {$base}/templates/{$template} where base is either JPATH_SITE or JPATH_ADMINISTRATOR.
See also: gantry/gantry5#114
this patch works for me, no more missing language strings on discover installations
Able to reproduce then #6835 works as expected both for admin & site templates.
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6835.
| Category | ⇒ | Administration Templates (admin) Templates (site) |
brianteeman
- | Status | New | ⇒ | Needs Review |
@test ok
After applying the patch I tested:
- Install admin template from folder
- Install admin template with discover
- Install admin template from zip
- Install site template from folder
- Install site template with discover
- Install site template from zip
About the discover issue fixed here this was the $source value before applying the patch:
site/templates/mytemplate (wrong)
And the $source value after applying the patch:
/home/roberto/www/jcms3x/templates/mytemplate (right)
I also tested the the $source value was ok for all my install tests.
So 
here
Well, like I said in the pull request comment, the source was wrong also for admin: ADMINISTRATOR/templates/mytemplate.
Fixing $source was the only real change in the patch; rest of it was just reusing the same variable.
Good to go, consistent with other adapters that have multi-client support.
zero-24
- | Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-04-25 14:50:19 |
| Closed_By | ⇒ | mbabker |
Thanks, will now look at my next small improvement for the installer.
| Labels |
Removed:
?
|
||
To test this:
Before applying the patch, you will see this message:
After the patch:
PS. You can repeat the same with admin template.