? ? ? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
23 Apr 2015

See #6816

This patch adds a Purge button in languages/overrides => Manager.
screen shot 2015-04-23 at 18 26 26

avatar infograf768 infograf768 - open - 23 Apr 2015
avatar coolman01
coolman01 - comment - 23 Apr 2015

Tested and functions as described.
Thank you

avatar JoshuaLewis
JoshuaLewis - comment - 23 Apr 2015

Just trying to better understand the purge function, so it's usage is mostly for caching situations with modifications? The message in the screen shot is what led me to this conclusion.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6827.

avatar infograf768
infograf768 - comment - 24 Apr 2015

@wilsonge
truncateTable implemented. Thanks

@JoshuaLewis
The overrider table is ONLY a cache table storing the strings for the language targeted (it does not contain the overrides created in language/overrides/xx-XX.override.ini) .
It is deleted and refilled when clicking in the search field.
See method refresh()
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_languages/models/strings.php#L26

What happens is that this table can become very heavy if overrides were created for many languages.
When moving the site and database, the table contains wrong path for the files containing the language strings. They are normally refreshed the first time one clicks in the search field.

I could not reproduce here the issue described by @coolman01 but it is not a big deal to add a Purge button for that table for people who have issues.

avatar brianteeman
brianteeman - comment - 24 Apr 2015

I know the table is called Overrider but thats not really English so can you change the message to use either the word override or overrides.

avatar coolman01
coolman01 - comment - 24 Apr 2015

Thanks guys, especially @infograf768 for your support here.

avatar infograf768
infograf768 - comment - 24 Apr 2015

I know the table is called Overrider but thats not really English so can you change the message to use either the word override or overrides.

Shall we let CMS maintainers decide about that? The table is called "overrider" and does not contain any override. Changing the name would create a confusion as it could be understood that the table contains the overrides.
Coca-Cola or Joomla! are not English either...

avatar brianteeman
brianteeman - comment - 24 Apr 2015

Fair enough and I see that the word table is in the string so I guess it is
OK (I was checking on my phone before which isn't so easy)

Please add a period at the end of the string to be in line with the ;en-GB
language style guide

On 24 April 2015 at 11:49, infograf768 notifications@github.com wrote:

I know the table is called Overrider but thats not really English so can
you change the message to use either the word override or overrides.

Shall we let CMS maintainers decide about that? The table is called
"overrider" and does not contain any override. Changing the name would
create a confusion as it could be understood that the table contains the
overrides.
Coca-Cola or Joomla! are not English either...


Reply to this email directly or view it on GitHub
#6827 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar infograf768
infograf768 - comment - 25 Apr 2015

Period added.

avatar brianteeman
brianteeman - comment - 25 Apr 2015

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6827.

avatar zero-24 zero-24 - alter_testresult - 29 Apr 2015 - coolman01: Tested successfully
avatar zero-24
zero-24 - comment - 29 Apr 2015

@test successful thanks :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6827.

avatar zero-24 zero-24 - test_item - 29 Apr 2015 - Tested successfully
avatar zero-24 zero-24 - change - 29 Apr 2015
Category Administration Language & Strings
avatar zero-24 zero-24 - change - 29 Apr 2015
Status New Ready to Commit
avatar zero-24
zero-24 - comment - 29 Apr 2015

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6827.

avatar wilsonge wilsonge - change - 25 May 2015
Labels Added: ?
avatar wilsonge
wilsonge - comment - 25 May 2015

Merged into 3.5-dev with fcac315

avatar wilsonge wilsonge - change - 25 May 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-05-25 00:30:29
Closed_By wilsonge
avatar wilsonge wilsonge - close - 25 May 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment