[#6810] - Use pk ci tag map
- Closed
- 17 Jun 2015
- Medium
- Build: staging
- # 6810
- Diff
- sovainfo:use_pk_ci_tag_map
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Performance improvement by accessing #_contentitem_tag_map via PK.
Instead of using the type_alias it uses the type_id which allows access through PK.
Testinstruction:
Filter on a tag in the backend
| Category | ⇒ | Administration Components SQL |
| Status | New | ⇒ | Information Required |
Moving to Information required until we have a response to @wilsonge's questions 
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6810.
@sovainfo Please can you respond to @wilsonge questions. Otherwise this will be closed automatically in a few weeks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6810.
Even if there is a performance gain (which there probably is, but very tiny), from a code perspective this is wrong. The ID should not be hardcoded into the extension. The extension should in fact not care about it at all.
Especially if we're going to decouple those extensions and make them installable again, this would fail because the ID would be different.
Rejecting based on code review.
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-17 20:55:33 |
| Closed_By | ⇒ | Bakual |
What's the kind of performance gain here. My worry about this is that many people use these components as a basis for building their own extensions (and yes that's a sign that we need to massively improve our documentation but that's not really the point here). Clearly there they aren't going to know what the primary key is and they should be using this method of searching by the alias (which should be unique) so unless there's some stupid performance gain to be had I'm kind of reluctant to change it to change it to hardcoded primary keys.