User tests: Successful: Unsuccessful:
com_user access.xml includes section name="category" but config.xml lacked a field with this section.
Labels |
Added:
?
|
Labels |
Removed:
?
|
Labels |
Added:
?
|
Category | ⇒ | ACL Administration Components |
Status | New | ⇒ | Pending |
@RonakParmar That is a good question. I opened this a long time ago as one of my first PR's for the Joomla project. Other than a code consistency item I'm not sure what the consequence of the config.xml lacking a field with section name="category" would be. I'm not even sure what would be the appropriate testing steps for this. (other than apply and check that the component still functions as expected).
I'm currently caught up in working on the code style and HHVM testing stuff so I'm not sure when I could take another look at this.
There are no categories for users, so this doesn't make any sense to add it here.
Also, the category permissions are set in the category by com_category. It's not something which has to be set in the components permission options.
Imho this PR should be closed.
User notes has categories, actual users do not. And the user note categories use the com_users
extension to identify those. It's all one big mess.
I honestly don't know. I legitimately haven't worked with any component needing a categories implementation except for core stuff.
@photodude If you doesn't do this you might face issue when categories for your extension can't be deleted from admin interface for example.
@alex7r Thanks, that's Good point that without this patch there is a possibility that the user note categories might not be able to be deleted through the admin interface.
I think I was using com_content as an example for why this PR was needed. Both the access.xml and the config.xml include the section name="category". So to be consistent I opened this PR.
@photodude can you email me at alex7r@ya.ru
I'd like to learn your vision on some problems and don't want to flood it all here.
Thanks.
I think I was using com_content as an example for why this PR was needed. Both the access.xml and the config.xml include the section name="category". So to be consistent I opened this PR.
The access.xml needs the category for com_content. Since you can set category permissions and they need to be checked. But the config.xml doesn't have a permission field for categories and doesn't need one imho. Neither in com_content nor in com_users nor in any other extension.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-18 02:38:42 |
Closed_By | ⇒ | photodude |
Can you please guide me what is the issue if I don't have category section?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6790.