? Success

User tests: Successful: Unsuccessful:

avatar photodude
photodude
16 Apr 2015

com_user access.xml includes section name="category" but config.xml lacked a field with this section.

avatar photodude photodude - open - 16 Apr 2015
avatar zero-24 zero-24 - change - 29 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 29 Apr 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 29 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 29 Apr 2015
Category ACL Administration Components
avatar zero-24 zero-24 - change - 29 Apr 2015
Status New Pending
avatar RonakParmar
RonakParmar - comment - 3 Jun 2016

Can you please guide me what is the issue if I don't have category section?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6790.

avatar photodude
photodude - comment - 3 Jun 2016

@RonakParmar That is a good question. I opened this a long time ago as one of my first PR's for the Joomla project. Other than a code consistency item I'm not sure what the consequence of the config.xml lacking a field with section name="category" would be. I'm not even sure what would be the appropriate testing steps for this. (other than apply and check that the component still functions as expected).

I'm currently caught up in working on the code style and HHVM testing stuff so I'm not sure when I could take another look at this.

avatar Bakual
Bakual - comment - 3 Jun 2016

There are no categories for users, so this doesn't make any sense to add it here.
Also, the category permissions are set in the category by com_category. It's not something which has to be set in the components permission options.

Imho this PR should be closed.

avatar photodude
photodude - comment - 3 Jun 2016

@Bakual does that mean that the com_user access.xml inclusion of a section name="category" is also wrong?

avatar mbabker
mbabker - comment - 3 Jun 2016

User notes has categories, actual users do not. And the user note categories use the com_users extension to identify those. It's all one big mess.

avatar photodude
photodude - comment - 3 Jun 2016

@mbabker is it necessary to include the section name="category" in both the access.xml and the config.xml for the user note categories to function correctly?

avatar mbabker
mbabker - comment - 3 Jun 2016

I honestly don't know. I legitimately haven't worked with any component needing a categories implementation except for core stuff.

avatar alex7r
alex7r - comment - 3 Jun 2016

@photodude If you doesn't do this you might face issue when categories for your extension can't be deleted from admin interface for example.

avatar photodude
photodude - comment - 3 Jun 2016

@alex7r Thanks, that's Good point that without this patch there is a possibility that the user note categories might not be able to be deleted through the admin interface.

I think I was using com_content as an example for why this PR was needed. Both the access.xml and the config.xml include the section name="category". So to be consistent I opened this PR.

avatar alex7r
alex7r - comment - 3 Jun 2016

@photodude can you email me at alex7r@ya.ru
I'd like to learn your vision on some problems and don't want to flood it all here.
Thanks.

avatar photodude
photodude - comment - 3 Jun 2016

@alex7r emailed as requested.

avatar Bakual
Bakual - comment - 3 Jun 2016

I think I was using com_content as an example for why this PR was needed. Both the access.xml and the config.xml include the section name="category". So to be consistent I opened this PR.

The access.xml needs the category for com_content. Since you can set category permissions and they need to be checked. But the config.xml doesn't have a permission field for categories and doesn't need one imho. Neither in com_content nor in com_users nor in any other extension.

avatar photodude
photodude - comment - 18 Jun 2016

Closing based on @Bakual comments

avatar photodude photodude - change - 18 Jun 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-06-18 02:38:42
Closed_By photodude
avatar photodude photodude - close - 18 Jun 2016

Add a Comment

Login with GitHub to post a comment