Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#6785] - Remove un-used variables from code

? Success

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
15 Apr 2015

PR summary

In the ModulesController and MenusController, there are some variables initialized/defined but not being used at all (It can be seen easily from smart IDE like phpstorm). This PR simply remove it.

Testing instructions

I think this PR just need a quick review from PLT and then it can be merged. However, if you want to test, just apply this PR, login to backend of your site, access to Menus -> Menu Manager, Extensions -> Module Manager, make sure these two pages still being displayed property and test is success.

avatar joomdonation joomdonation - open - 15 Apr 2015
avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2015
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Apr 2015

Works as described

avatar joomdonation
joomdonation - comment - 21 Apr 2015

Thanks @franz-wohlkoenig for testing the PR.

avatar zero-24 zero-24 - change - 29 Apr 2015
Category ⇒ Code style
avatar zero-24 zero-24 - change - 29 Apr 2015
Easy No ⇒ Yes
avatar zero-24 zero-24 - alter_testresult - 29 Apr 2015 - franz-wohlkoenig: Tested successfully
avatar Dylis
Dylis - comment - 9 May 2015

@test - Pages still displaying correctly after patching

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6785.

avatar Dylis Dylis - test_item - 9 May 2015 - Tested successfully
avatar zero-24 zero-24 - change - 9 May 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 9 May 2015

Thanks for testing. RTC'ing now :smile:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6785.

avatar zero-24 zero-24 - change - 9 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 9 May 2015
Labels Added: ?
avatar mbabker mbabker - change - 9 May 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-05-09 15:35:04
Closed_By ⇒ mbabker
avatar mbabker mbabker - close - 9 May 2015
avatar mbabker mbabker - reference | 400f242 - 9 May 15
avatar mbabker mbabker - merge - 9 May 2015
avatar mbabker mbabker - close - 9 May 2015
avatar zero-24 zero-24 - close - 9 May 2015
avatar zero-24 zero-24 - change - 9 May 2015
Milestone Added:
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?
avatar joomdonation joomdonation - head_ref_deleted - 19 Dec 2015

Add a Comment

Login with GitHub to post a comment