[#6774] - Small change to com_tags backend
- Closed
- 14 Apr 2015
- Medium
- Build: staging
- # 6774
- Diff
- joomdonation:patch-8
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR just contains two small changes to com_tags backend:
Standardize component entry point, make it the same with other component.
Remove call to a wrong implemented method TagsHelper::addSubmenu('tags'); This command doesn't affect the extension at all.
This method https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_tags/helpers/tags.php#L28 is based on CategoriesHelper::addSubmenu (https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_categories/helpers/categories.php#L28) but it was implemented in a wrong way, incomplete and not used anywhere (at least in core code), Not sure what to do with it: Leave it there, empty it or remove it :D ?
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Milestone |
Added: |
||
Thanks George. Made the change and Travis is happy now. Please help review and merge it when you have time.
Applied with com_patchtester to J341. Backend tags still works.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6774.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-04-14 17:01:29 |
Very simple set of changes so merging on the one test and my code review
I think this PR just need a quick review from PLT to get it merged.