?
avatar dgt41
dgt41
13 Apr 2015

I recently went ahead and installed chrome vox plugin and tried it on backend with isis. There are many things that needs to be improved, but the most obvious is the faulty hidden sidebar. So try this:
go to administrator/index.php?option=com_users&view=users
and HIDE the sidebar!
now start navigating with the tab
the order after the help button on the toolbar is wrong!
It should be highlighting the search field but instead is highlighting the hidden elements of the sidebar!

How to solve this?
The script that hides/shows the sidebar should also inject aria-hidden="true" to the ul element when that is hidden and remove it when the sidebar is viewable.

avatar dgt41 dgt41 - open - 13 Apr 2015
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 29 Apr 2015
Category Accessibility Administration
avatar vinespie vinespie - reference | 12bc2db - 13 May 15
avatar vinespie vinespie - reference | 704254c - 13 May 15
avatar vinespie
vinespie - comment - 13 May 2015

Adding attributes "aria-hidden" set to "true" and "tabindex" set to "-1" when sidebar is hidden. If visible these attributes are removed. Fix #6758

Test instructions

  1. Go to Admin
  2. Go to users manager / article manager
  3. Hide the sidebar
  4. Start navigation with the tab
  5. After the help button, you must go to search field
  6. Show the the sidebar
  7. Restart navigation whith the tab
  8. You must pass in the sidebar links
avatar dgt41
dgt41 - comment - 13 May 2015

@vinespie I think you should open a pull request against staging, so we can close this issue. Other than that :+1:

avatar vinespie
vinespie - comment - 13 May 2015

@dgt41I can not go back on the commit. Can you give me a tip?

avatar dgt41
dgt41 - comment - 13 May 2015

Try:
https://github.com/joomla/joomla-cms/pulls
press the green button New Pull Request
click on "compare across forks"
Select joomla staging and vinespie staging
Then just name the PR e.g. Accessibility enhancement for sidebar
and copy paste the description and testing instructions from here!

avatar roland-d
roland-d - comment - 22 May 2015

@dgt41 This can't be merged since there is no pull request. Let's wait until @vinespie made his pull request.

avatar dgt41
dgt41 - comment - 24 May 2015

There is a PR #7024 that solves this

avatar dgt41 dgt41 - change - 24 May 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-05-24 14:38:51
Closed_By dgt41
avatar dgt41 dgt41 - close - 24 May 2015

Add a Comment

Login with GitHub to post a comment