? Success
Referenced as Related to: # 7200

User tests: Successful: Unsuccessful:

avatar oc666
oc666
11 Apr 2015

Currently the protostar sub-menu on RTL is not aligned well. This PR fix it.
Before:
image
After:
image

avatar oc666 oc666 - open - 11 Apr 2015
avatar brianteeman brianteeman - change - 11 Apr 2015
Easy No Yes
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 11 Apr 2015
Category RTL Templates (site)
avatar infograf768
infograf768 - comment - 11 Apr 2015

I suggest you rather add the classes to bootstrap-rtl.less where we already have some stuff for frontend.
Then run generatecss.php

This will not make necessary to add a rtl.css to Protostar and load it.

avatar infograf768
infograf768 - comment - 11 Apr 2015

Also Careful: the "initial" value may not work with IE.

avatar oc666
oc666 - comment - 11 Apr 2015

I don't understand why require to add to bootstrap-rtl if this is specific issue for protostar.
Anyway, I changed the left initial to left auto.

avatar infograf768
infograf768 - comment - 12 Apr 2015

@oc666
Until today, even when I suggested it when Protostar was created, nobody wanted to create a specific rtl.less and subsequently a rtl.css for protostar. Thus the reason of my post.

If PLT agrees to add now a rtl.css to protostar, I have no issue with it, but should also be created a rtl.less and generatecss.php should be modify to include this new setting, i.e. add

JPATH_SITE . '/templates/protostar/less/template_rtl.less' => JPATH_SITE . '/templates/protostar/css/template_rtl.css',

line 55 of https://github.com/joomla/joomla-cms/blob/staging/build/generatecss.php#L55

the new code shoudl be added in the new .less file and generatecss.php used.

avatar phproberto
phproberto - comment - 12 Apr 2015

IMO the right way would be to add a class for the html or body tags when a RTL language is active. Then use it to define specific behaviors for rtl languages in a new rtl.less inside protostar. Then you only have to import it in template.less without needing to modify template index.php or generatecss.php.... And you save to have 2 css files loaded (2 requests).

avatar brianteeman
brianteeman - comment - 17 Jun 2015

@oc666 can you look at the suggestion from @phproberto so that we can get this important fix made in the core


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6740.

avatar infograf768
infograf768 - comment - 19 Jun 2015

See #7200 implementing @phproberto solution.

avatar brianteeman brianteeman - change - 19 Jun 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-06-19 08:14:19
Closed_By brianteeman
avatar brianteeman
brianteeman - comment - 19 Jun 2015

Closed in favour of #7200


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6740.

avatar brianteeman brianteeman - close - 19 Jun 2015

Add a Comment

Login with GitHub to post a comment