? ? Success

User tests: Successful: Unsuccessful:

avatar peterlose
peterlose
8 Apr 2015

Some updates for the admin footer, primarily in mod_status

Before PR

skaermbillede 2015-04-09 kl 00 35 26

After PR

skaermbillede 2015-04-09 kl 00 35 33

55dd231 8 Apr 2015 avatar peterlose CS
765730e 8 Apr 2015 avatar peterlose CS
0fdb3c7 8 Apr 2015 avatar peterlose CS
avatar losedk losedk - open - 8 Apr 2015
avatar joomla-cms-bot joomla-cms-bot - change - 8 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 8 Apr 2015
Category Templates (admin) UI/UX
08f253e 8 Apr 2015 avatar peterlose CS
avatar n9iels
n9iels - comment - 9 Apr 2015

Looks good, thanks!

@test when you enable the admin module "Multilanguage status" this happen:
footer

Maybe also a good idea to test the compability with extensions that add a footer option, like Nonumer Cache cleaner.

avatar n9iels
n9iels - comment - 9 Apr 2015

off topic: Am I the only on who gets a white page when clicking on a picture, and has to reload that page to see the picture? I'm working on the latest version of Google Chrome

avatar infograf768
infograf768 - comment - 9 Apr 2015

This does not look right.
Changing the messages plural strings by taking off the variable is wrong imho as JText::plural is used, and rightfully so as the order of the figure (the variable) in the value is depending on the language.

avatar losedk
losedk - comment - 9 Apr 2015

@infograf768 don't entirely understand the issue. There aren't any variables on the other language strings and they are using JText::plural

avatar infograf768
infograf768 - comment - 9 Apr 2015

code is;
<?php echo JText::plural('MOD_STATUS_MESSAGES', $unread); ?>

this expects a variable ($unread) in the string value depending on plural form:
therefore
this change is wrong

-MOD_STATUS_MESSAGES_0="%d Messages"
-MOD_STATUS_MESSAGES_1="%d Message"
-MOD_STATUS_MESSAGES_MORE="%d Messages"
+MOD_STATUS_MESSAGES_0="Messages"
+MOD_STATUS_MESSAGES_1="Message"
+MOD_STATUS_MESSAGES_MORE="Messages"

to display 1 message ( $unread = 1) using MOD_STATUS_MESSAGES_1="%d Message"
or 2 messages ($unread = 2) using MOD_STATUS_MESSAGES_MORE="%d Messages"

avatar mbabker
mbabker - comment - 9 Apr 2015

The other badges haven't had the number in the string since 3.0, for better or worse. The redesign split it so the number is in a badge and the text is only what it is describing. To be fully correct for languages, the badge HTML should probably be in the strings.

avatar infograf768
infograf768 - comment - 9 Apr 2015

You are totally right. Weird.
Tested by taking off the variable in the string value and no change in case string is not updated.

avatar infograf768
infograf768 - comment - 9 Apr 2015

This breaks the display in Hathor though.

before PR:

screen shot 2015-04-09 at 18 28 34

after PR
screen shot 2015-04-09 at 18 27 10

avatar losedk
losedk - comment - 9 Apr 2015

Thanks for the comments. I'll add the changes and fixes

avatar davdebcom
davdebcom - comment - 10 Apr 2015

@roland-d @brianteeman Guys, does the status need to be changed to "Information required" or something so we don't get PBF testers checking this one?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6713.

avatar zero-24 zero-24 - change - 10 Apr 2015
Status Pending Information Required
avatar zero-24
zero-24 - comment - 10 Apr 2015

Done @davdebcom if @losedk fixes the issues please let us know so we can move it back to Pending :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6713.

avatar losedk
losedk - comment - 10 Apr 2015

Yeah. I'm gonna look at it tomorrow :)

avatar losedk
losedk - comment - 12 Apr 2015

@n9iels Would this be okay for the multi language module issue:

Status in bottom

skaermbillede 2015-04-12 kl 16 47 59

Status in top

skaermbillede 2015-04-12 kl 16 48 16

avatar zero-24 zero-24 - change - 12 Apr 2015
Status Information Required Pending
avatar n9iels
n9iels - comment - 13 Apr 2015

yes, that looks good to me :-)

avatar zero-24 zero-24 - alter_testresult - 13 Apr 2015 - n9iels: Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Apr 2015

Works as described

avatar losedk
losedk - comment - 23 Apr 2015

Pushed some updates, but I'm not entirely sure of how to resolve the merge conflicts.

avatar n9iels
n9iels - comment - 23 Apr 2015

@test works good for the Joomla! core, but seems like it doesn't work well with 3e part extensions:
knipsel

knipsel

avatar losedk losedk - change - 24 May 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-05-24 13:10:53
Closed_By losedk
avatar losedk losedk - close - 24 May 2015
avatar joomla-cms-bot joomla-cms-bot - close - 24 May 2015
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment