User tests: Successful: Unsuccessful:
Labels |
Added:
?
|
Category | ⇒ | Templates (admin) UI/UX |
off topic: Am I the only on who gets a white page when clicking on a picture, and has to reload that page to see the picture? I'm working on the latest version of Google Chrome
This does not look right.
Changing the messages plural strings by taking off the variable is wrong imho as JText::plural is used, and rightfully so as the order of the figure (the variable) in the value is depending on the language.
@infograf768 don't entirely understand the issue. There aren't any variables on the other language strings and they are using JText::plural
code is;
<?php echo JText::plural('MOD_STATUS_MESSAGES', $unread); ?>
this expects a variable ($unread) in the string value depending on plural form:
therefore
this change is wrong
-MOD_STATUS_MESSAGES_0="%d Messages"
-MOD_STATUS_MESSAGES_1="%d Message"
-MOD_STATUS_MESSAGES_MORE="%d Messages"
+MOD_STATUS_MESSAGES_0="Messages"
+MOD_STATUS_MESSAGES_1="Message"
+MOD_STATUS_MESSAGES_MORE="Messages"
to display 1 message ( $unread = 1) using MOD_STATUS_MESSAGES_1="%d Message"
or 2 messages ($unread = 2) using MOD_STATUS_MESSAGES_MORE="%d Messages"
The other badges haven't had the number in the string since 3.0, for better or worse. The redesign split it so the number is in a badge and the text is only what it is describing. To be fully correct for languages, the badge HTML should probably be in the strings.
You are totally right. Weird.
Tested by taking off the variable in the string value and no change in case string is not updated.
Thanks for the comments. I'll add the changes and fixes
@roland-d @brianteeman Guys, does the status need to be changed to "Information required" or something so we don't get PBF testers checking this one?
Status | Pending | ⇒ | Information Required |
Done @davdebcom if @losedk fixes the issues please let us know so we can move it back to Pending
Yeah. I'm gonna look at it tomorrow :)
Status | Information Required | ⇒ | Pending |
yes, that looks good to me :-)
Works as described
Pushed some updates, but I'm not entirely sure of how to resolve the merge conflicts.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-24 13:10:53 |
Closed_By | ⇒ | losedk |
Labels |
Added:
?
|
Looks good, thanks!
@test when you enable the admin module "Multilanguage status" this happen:
Maybe also a good idea to test the compability with extensions that add a footer option, like Nonumer Cache cleaner.