Feeling Lucky
?
[#6701] - Add type to the extension query
- Closed
- 8 Apr 2015
- Medium
- Build: staging
- # 6701
- Diff
- Bakual:FixComponentHelperIsinstal
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
See #6697 for initial report and testing instructions.
In short: JComponentHelper::isInstalled($option) currently only checks the element column, but it should also filter by the type so only components are returned.
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- comment
- 8 Apr 2015
is this different to #6697
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6701.
Bakual
- comment
- 8 Apr 2015
Not really. For some reason (probably blindness) I didn't see his PR.
Closing.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-04-08 08:56:51 |
Testing instructions copied from the initial report:
Steps to reproduce the issue
1) Uninstall weblinks
2) Install OSMap (https://github.com/OSTraining/OSMap/releases/download/v3.0.2/com_osmap_free_3.0.2.zip)
3) In the administrator control panel (administrator/index.php), you should see an internal server error for the "Site Information" module:
Expected result
The "Site Information" module should work. I'm guessing the error should be caught and it should degrade gracefully.
Actual result
Error 1146: Table '_weblinks' doesn't exist SQL=SELECT COUNT(id) AS count_links FROM _weblinks WHERE state = 1
Additional comments
It's because of this code:
https://github.com/joomla/joomla-cms/blob/3.4.1/libraries/cms/component/helper.php#L102
It's querying for the "element", however the weblinks plugin in OSMap uses an element of "com_weblinks" because it's a weblinks plugin.