Feeling Lucky
?
[#6692] - Moves GMail plugin to use the Joomla HTTP library
- Closed
- 11 Jul 2015
- Medium
- Build: staging
- Easy Test
- # 6692
- Diff
- wilsonge:gmailhttp
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This utilises a framework PR (joomla-framework/http#12) to extend the transport options in Joomla for the SSL request. Currently to keep things incremental the plugin still only uses Curl, but in the future may allow to use other request methods that are available.
To test you can check that the Gmail authentication plugin still verifies users properly
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- comment
- 7 Apr 2015
@wilsonge on login with this patch applyed i get:
Catchable fatal error: Argument 1 passed to JHttp::__construct() must be an instance of Joomla\Registry\Registry, array given, called in JROOT/plugins/authentication/gmail/gmail.php on line 67 and defined in JROOT/libraries/joomla/http/http.php on line 42
| Easy | No | ⇒ | Yes |
| Category | ⇒ | External Library Plugins |
Fixed along with the changes 
davdebcom
- comment
- 10 Apr 2015
@test
Gmail login still seems to be working after patch.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6692.
brianteeman
- comment
- 21 Jun 2015
Tested with all the options in the plugin and gmail authentication still works
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6692.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 21 Jun 2015
Setting RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6692.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-11 14:03:07 |
| Closed_By | ⇒ | mbabker |
| Labels |
Removed:
?
|
||
@wilsonge i have just send you a PR: wilsonge#11 to fix codestyle. I will try to test now