? Success

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
7 Apr 2015

CodeMirror got an update so here's the CodeMirror update.

Release notes: http://codemirror.net/doc/releases.html

avatar okonomiyaki3000 okonomiyaki3000 - open - 7 Apr 2015
avatar joomla-cms-bot joomla-cms-bot - change - 7 Apr 2015
Labels Added: ?
avatar wilsonge wilsonge - close - 7 Apr 2015
avatar wilsonge
wilsonge - comment - 7 Apr 2015

Someone got there ahead of you this time :p see #6589

avatar wilsonge wilsonge - change - 7 Apr 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-04-07 09:26:09
avatar wilsonge wilsonge - close - 7 Apr 2015
avatar okonomiyaki3000
okonomiyaki3000 - comment - 8 Apr 2015

@wilsonge Don't use that one. It's not correct. Use mine.

avatar wilsonge wilsonge - change - 8 Apr 2015
Status Closed New
avatar wilsonge wilsonge - reopen - 8 Apr 2015
avatar wilsonge wilsonge - reopen - 8 Apr 2015
avatar okonomiyaki3000
okonomiyaki3000 - comment - 8 Apr 2015

CodeMirror has a lot of addons, we want to use some but we definitely don't need all. So it's best to compile all the ones we do need into an addons file so they can be included easily. Also, everything should be minified. I have a shell script that does this for me so it's easy for me to keep CM up to date. I don't really think I should be a single point of failure for this though.

avatar wilsonge
wilsonge - comment - 8 Apr 2015

I'll make a docs page tomorrow so we have instructions for tiny and code mirror in one place :) Thanks for the information tho - it's really appreciated!

avatar brianteeman
brianteeman - comment - 8 Apr 2015

Elijah can you make sure to share your script on the docs page George
creates to avoid the "single point of failure"

On 8 April 2015 at 01:31, George Wilson notifications@github.com wrote:

I'll make a docs page tomorrow so we have instructions for tiny and code
mirror in one place :) Thanks for the information tho - it's really
appreciated!


Reply to this email directly or view it on GitHub
#6686 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar okonomiyaki3000
okonomiyaki3000 - comment - 8 Apr 2015

@brianteeman I was thinking that it might be better to remake it with something like grunt which might somehow preferable to bash. What do you think?

avatar brianteeman
brianteeman - comment - 8 Apr 2015

No comment from me on technical details - its beyond my payscale.

My concern is the bus not how it is driven ;)

On 8 April 2015 at 09:22, Elijah Madden notifications@github.com wrote:

@brianteeman https://github.com/brianteeman I was thinking that it
might be better to remake it with something like grunt which might somehow
preferable to bash. What do you think?


Reply to this email directly or view it on GitHub
#6686 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar Bakual
Bakual - comment - 8 Apr 2015

@okonomiyaki3000 As long as it works and isn't some funny esotheric format, I don't mind if it is bash or grunt :smile:

avatar zero-24 zero-24 - change - 8 Apr 2015
Status New Pending
avatar wilsonge wilsonge - change - 8 Apr 2015
Milestone Added:
avatar zero-24 zero-24 - change - 8 Apr 2015
Category External Library
avatar okonomiyaki3000
okonomiyaki3000 - comment - 9 Apr 2015

This is the first time I've used Grunt so please speak up if you notice that I've done anything weird. There's probably a lot of room for improvement but somehow I feel this is better than a bash script.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 27 Apr 2015

5.2 is out. http://codemirror.net/doc/releases.html

Also, I updated the builder, making it a bit easier to understand: https://github.com/okonomiyaki3000/joomla-codemirror-builder

avatar wilsonge wilsonge - change - 27 Apr 2015
Title
CodeMirror 5.1
CodeMirror 5.2
avatar okonomiyaki3000 okonomiyaki3000 - change - 26 May 2015
Title
CodeMirror 5.2
CodeMirror 5.3
avatar okonomiyaki3000
okonomiyaki3000 - comment - 26 May 2015

5.3 now. It doesn't seem to be an urgent update. Maybe it doesn't contain anything special for Joomla users but it's best to stay up to date.

Also, I've updated the builder again. Now using bower instead of curl to get the latest CM, it greatly simplifies the grunt tasks.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 29 May 2015

I must be confused. I guess I have too many branches.

avatar okonomiyaki3000 okonomiyaki3000 - change - 29 May 2015
Title
CodeMirror 5.2
CodeMirror 5.3
avatar wilsonge wilsonge - reference | ad81cf7 - 29 May 15
avatar wilsonge
wilsonge - comment - 29 May 2015

Merged with ad81cf7

Thankyou very much!

avatar wilsonge wilsonge - change - 29 May 2015
Status Pending Closed
Closed_Date 2015-04-07 09:26:09 2015-05-29 20:07:41
Closed_By wilsonge
avatar wilsonge wilsonge - close - 29 May 2015
avatar wilsonge wilsonge - close - 29 May 2015
avatar okonomiyaki3000 okonomiyaki3000 - head_ref_deleted - 1 Jun 2015

Add a Comment

Login with GitHub to post a comment