Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#6682] - Module Manager. Integrate searchtools bar (instead filters in sidebar).

? ? Success

User tests: Successful: Unsuccessful:

avatar bertmert
bertmert
6 Apr 2015

Also fixes feature request
#6656

Possible conflicts with other PRs (but easy to fix):

1) #6673
https://github.com/bertmert/joomla-cms/blob/patch-9/administrator/components/com_modules/views/modules/tmpl/default.php#L249-L254

2) #6677
#6677 (comment)

Test:

  • Go to Extensions > Module Manager.
  • Before patch:

All filters in sidebar.

com_modules-manager1

Check also issue #6661
Check also issue/request #6656

  • After patch

com_modules-manager2

avatar bertmert bertmert - open - 6 Apr 2015
avatar joomla-cms-bot joomla-cms-bot - change - 6 Apr 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 6 Apr 2015
Labels Added: ?
avatar infograf768
infograf768 - comment - 7 Apr 2015

Looks pretty good here.

avatar zero-24 zero-24 - change - 7 Apr 2015
Category ⇒ Templates (admin) UI/UX
avatar bertmert bertmert - reference | - 7 Apr 15
avatar bertmert
bertmert - comment - 8 Apr 2015

@test @aasimali confirmed another successful test here: #6656 (comment)

@zero-24 Thank you for code review!

avatar ihuibregtse ihuibregtse - test_item - 10 Apr 2015 - Tested successfully
avatar dam-man
dam-man - comment - 10 Apr 2015

@test
Patch is working and better than current previous filtering.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6682.
avatar zero-24 zero-24 - change - 10 Apr 2015
Status Pending ⇒ Ready to Commit
avatar dam-man dam-man - test_item - 10 Apr 2015 - Tested successfully
avatar zero-24 zero-24 - alter_testresult - 10 Apr 2015 - aasimali: Tested successfully
avatar zero-24
zero-24 - comment - 10 Apr 2015

Thanks to the tester and coder! RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6682.

avatar zero-24 zero-24 - change - 10 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 10 Apr 2015
Labels Added: ?
avatar roland-d roland-d - change - 10 Apr 2015
Milestone Added:
avatar roland-d roland-d - change - 10 Apr 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-04-10 14:53:24
avatar roland-d roland-d - close - 10 Apr 2015
avatar roland-d roland-d - close - 10 Apr 2015
avatar roland-d roland-d - close - 10 Apr 2015
avatar joomla-cms-bot joomla-cms-bot - close - 10 Apr 2015
avatar bertmert bertmert - reference | a4545a1 - 10 Apr 15
avatar infograf768
infograf768 - comment - 8 May 2015

This has caused a regression in Hathor where we can't change the client anymore.
See #6673 (comment)

avatar bertmert
bertmert - comment - 8 May 2015

@zero-24 @roland-d @infograf768 Yes, buggy. Please remove RTC and close/remove this PR. I don't find a way to solve conflicts between Hathor and Isis in model modules.php described by infograf768. I don't know why all my tests then seemed to be successfull.
(Maybe because I tested with applied patch #6677 but I don't know).
Maybe someone will take over later. Then it's better to close this one because I will not have time for longer investigations. Sorry.

avatar roland-d roland-d - change - 8 May 2015
Milestone Removed:
Labels Removed: ?
avatar roland-d roland-d - change - 8 May 2015
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2015
Labels Added: ?
avatar roland-d roland-d - change - 8 May 2015
Milestone Removed:
avatar Bakual Bakual - reference | 69378d4 - 9 May 15
avatar Bakual
Bakual - comment - 9 May 2015

Reverted this PR due to the issues mentioned.
Feel free to propose a new PR.

avatar bertmert bertmert - head_ref_deleted - 15 May 2015
avatar johanjanssens johanjanssens - reference | 6f8ded4 - 19 Jun 15

Add a Comment

Login with GitHub to post a comment