Feeling Lucky
?
[#6680] - CLEANING-JDatabaseQuery
- Closed
- 25 Sep 2015
- Medium
- Build: staging
- # 6680
- Diff
- Mathewlenning:CLEANING-JDatabaseQuery
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Moved the JDatabaseQueryElement to is own file, because there is nothing gained by having multiple classes in a single file and it violates the naming conventions.
I also make the constructor element an optional null value, this isn't a BC break, because it was required before, so anyone using it will be sending a value.
Making it optional in the constructor allow us to remove all the if/else clauses in the JDatabaseQuery class.
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Libraries |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-09-25 13:19:50 |
| Closed_By | ⇒ | Mathewlenning |
I don't know what the deal with the getActive() method, but I'll have to look into it tomorrow. I've reached my bed time today. Happy Joomla!ng