Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#6666] - Handle DB errors in users latest module

? Success

User tests: Successful: Unsuccessful:

avatar alikon
alikon
5 Apr 2015

updated to handle DB errors like #6612 ,#6632, #6665 and for #6591

Testing info
set the db offline
or
simulate a db error
change line 37 from

->from('#__users AS a');

to

->from('#__users AS z');

before patch you get
trycatch

after you get
the module is not displayed

avatar alikon alikon - open - 5 Apr 2015
avatar joomla-cms-bot joomla-cms-bot - change - 5 Apr 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 5 Apr 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 5 Apr 2015
Milestone Added:
avatar alikon alikon - reference | - 6 Apr 15
avatar alikon alikon - reference | - 6 Apr 15
avatar zero-24 zero-24 - change - 6 Apr 2015
Category ⇒ Modules SQL
avatar alikon alikon - reference | - 8 Apr 15
avatar alikon alikon - reference | - 8 Apr 15
avatar alikon alikon - reference | - 8 Apr 15
avatar alikon alikon - reference | - 8 Apr 15
avatar alikon alikon - reference | - 8 Apr 15
avatar davdebcom davdebcom - test_item - 10 Apr 2015 - Tested successfully
avatar davdebcom davdebcom - test_item - 10 Apr 2015 - Tested successfully
avatar davdebcom
davdebcom - comment - 10 Apr 2015

@test
Works, after patch you don't see a SQL error anymore.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6666.

avatar nonumber
nonumber - comment - 10 Apr 2015

Not sure if this should get merged with regards to discussion on #6710

avatar anibalsanchez
anibalsanchez - comment - 6 Jun 2015

@test OK, no frontend SQL error showing internal information

(though it would be nice to show a generic error... instead of eating the excepton)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6666.

avatar anibalsanchez anibalsanchez - test_item - 6 Jun 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 6 Jun 2015

@alikon can you add the generic message also here? Like: https://github.com/joomla/joomla-cms/pull/6700/files

avatar alikon
alikon - comment - 7 Jun 2015

@anibalsanchez , @zero-24 thx for reporting
the generic msg was added

avatar zero-24 zero-24 - change - 7 Jun 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 7 Jun 2015

RTC Thanks :smile:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6666.

avatar zero-24 zero-24 - change - 7 Jun 2015
Labels Added: ?
avatar Bakual Bakual - change - 16 Jun 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-06-16 11:32:00
Closed_By ⇒ Bakual
avatar Bakual Bakual - close - 16 Jun 2015
avatar zero-24 zero-24 - close - 16 Jun 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment