[#6633] - Pagination layout. Missing icons and weird display
- Closed
- 12 Jun 2015
- Medium
- Build: staging
- # 6633
- Diff
- bertmert:patch-7
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Test:
- Rename /administrator/templates/isis/html/pagination.php to paginationxxxxxxxxxxxxxx.php
- Thus, Isis uses pagination from layouts/joomla/pagination/link.php
- Now, see backend list views, e.g. article manager:
Pagination in Joomla staging
Pagination in Joomla Staging after patch
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Title |
|
||||||
@infograf768 Yes, sorry. Please see added test instructions above.
Works OK for what it wants to solve.
Note: Using the layout gives weird display. A supplementary Display dropdown + the pagination bar is not any more aligned left.
Note: Using the layout gives weird display. A supplementary Display dropdown + the pagination bar is not any more aligned left.
I've added a second commit.
| Title |
|
||||||
| Title |
|
||||||
| Category | ⇒ | Layout |
thanks!
works good,
but I would not change $showLimitBox = $options->get('showLimitBox', false);, because it could have effect on extension that already expect different "default value"
but I would not change $showLimitBox = $options->get('showLimitBox', false);, because it could have effect on extension that already expect different "default value"
@Fedik @infograf768 @all Please discuss ;-) I really don't know if we should ignore B/C here or not.
I do not see a reason to change this part of code.
I've tested this and the patch solves the issue. Please note the pagination becomes left-aligned after the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6633.
| Status | Pending | ⇒ | Ready to Commit |
RTC based on various testing Thanks 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6633.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
Doesn't this break each template which uses that (default) JLayout?
No core component or core template is using this JLayout.
I'm using it in a FE template but use an override because of missing icons and hard coded center style.
Another alternative would be to add missing icon-classes to /media/jui/less/icomoon.less
Close PR and remove RTC please if you see B/C issues.
As I understand it, this is the default pagination layout used if no overrides are present? I haven't checked in detail but it's what I would expect.
It may be that core templates don't use this, but if there is a chance that 3rd party templates use it, then we can't simply change it and make those templates break.
You could maybe add additional classes to the output, having it contain two classes instead of replacing it.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-12 21:37:26 |
| Closed_By | ⇒ | bertmert |
Please remove RTC.
| Labels |
Removed:
?
|
||
| Labels |
Removed:
?
|
||
It's an issue of time that I don't have at the moment and the next weeks. I think PR is not that important and easy to reproduce if so. wants to take over..
I can't reproduce this issue. Icons display here in staging. Their Css are present.
