User tests: Successful: Unsuccessful:
Trashed menu items use the "unpublished" icon instead of the "trashed" icon in backend. This patch should fix this issue without affecting any other behavior. Issue was originally reported by user Cartho on joomla-bugs.de: http://www.joomla-bugs.de/forum/index.php/topic,665.0.html
As mentioned, the patch only changes the icon. For reasons of consistency, I have two more proposals where I'd like to request for some comments:
I'm not sure if the tooltips "Publish menu item::Component disabled" and "Component disabled and menu item unpublished." are the correct ones to use for the "trashed" state (-2).
In com_content (list of articles), we have a button group containing the status icon, featured icon and a dropdown with the actions "trash" and "archive". Is there any point against doing this the same way in com_menus? Instead of "featured" we could use the "default" marker (instead of having a separate column), the dropdown could be replaced with a single trash icon, because we don't have an "archived" state for menu items AFAIK.
Labels |
Added:
?
|
Category | ⇒ | Administration |
@test works fine for me!
I only test the bug, not the addition items
Status | Pending | ⇒ | Ready to Commit |
Thanks for the tests here! And also for fixing the issue. Moving to RTC now!
Labels |
Added:
?
|
Thank you guys for testing! I'll create two more PRs for the remaining questions soon.
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-04-04 12:46:13 |
Labels |
Removed:
?
|
Please open a separate issue for the additional items.