? Success

User tests: Successful: Unsuccessful:

avatar Harmageddon
Harmageddon
1 Apr 2015

Issue description

Trashed menu items use the "unpublished" icon instead of the "trashed" icon in backend. This patch should fix this issue without affecting any other behavior. Issue was originally reported by user Cartho on joomla-bugs.de: http://www.joomla-bugs.de/forum/index.php/topic,665.0.html

Testing instructions

  1. Go to "Menus - Your Menu" in backend to see the list of menu items.
  2. Trash one or more menu items.
  3. Set the "state" filter to "trashed" or "all" to display trashed items.
  4. Apply the patch.
  5. Make sure the icon is now correct and all actions still work, in particular:
    • "untrash" an item by clicking the trash icon.
    • "untrash" one or more items by selecting some and clicking the "clear trash" button when the state filter is set to "trashed".
    • trash one or more items by selecting some and clicking the "trash" button.

Further proposals

As mentioned, the patch only changes the icon. For reasons of consistency, I have two more proposals where I'd like to request for some comments:

1) Change the tooltips

I'm not sure if the tooltips "Publish menu item::Component disabled" and "Component disabled and menu item unpublished." are the correct ones to use for the "trashed" state (-2).

2) Use the same state buttons as in com_content

In com_content (list of articles), we have a button group containing the status icon, featured icon and a dropdown with the actions "trash" and "archive". Is there any point against doing this the same way in com_menus? Instead of "featured" we could use the "default" marker (instead of having a separate column), the dropdown could be replaced with a single trash icon, because we don't have an "archived" state for menu items AFAIK.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar Harmageddon Harmageddon - open - 1 Apr 2015
avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 1 Apr 2015

Please open a separate issue for the additional items.

avatar Harmageddon Harmageddon - change - 1 Apr 2015
Category Administration
avatar Engholm Engholm - test_item - 2 Apr 2015 - Tested successfully
avatar n9iels
n9iels - comment - 2 Apr 2015

@test works fine for me!
I only test the bug, not the addition items


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6629.
avatar n9iels n9iels - test_item - 2 Apr 2015 - Tested successfully
avatar zero-24 zero-24 - change - 2 Apr 2015
Status Pending Ready to Commit
avatar bertmert
bertmert - comment - 2 Apr 2015

@test success

avatar zero-24 zero-24 - alter_testresult - 2 Apr 2015 - n9iels: Tested successfully
avatar zero-24 zero-24 - alter_testresult - 2 Apr 2015 - bertmert: Tested successfully
avatar zero-24
zero-24 - comment - 2 Apr 2015

Thanks for the tests here! And also for fixing the issue. Moving to RTC now!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6629.
avatar zero-24 zero-24 - change - 2 Apr 2015
Labels Added: ?
avatar Harmageddon
Harmageddon - comment - 2 Apr 2015

Thank you guys for testing! I'll create two more PRs for the remaining questions soon.

avatar infograf768 infograf768 - reference | - 4 Apr 15
avatar infograf768
infograf768 - comment - 4 Apr 2015

Folks, please test #6641 which includes this PR and also solves the System Links tips and icon when trashed.
If tests OK for #6641 no use to merge this one.

avatar wilsonge
wilsonge - comment - 4 Apr 2015

Merged as part of #6641 -thanks for submitting this :)

avatar wilsonge wilsonge - change - 4 Apr 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-04-04 12:46:13
avatar wilsonge wilsonge - close - 4 Apr 2015
avatar zero-24 zero-24 - close - 4 Apr 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment