[#6625] - Regression: #4397 dropped tags when info block at the bottom
- Closed
- 4 Apr 2015
- Medium
- Build: staging
- Easy Test
- # 6625
- Diff
- sovainfo:patch-25
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Show tags when info block at the bottom for Featured Article menu item.
#4397 implements the layout of the info block. At the same time it dropped the tags when the info block is configured to appear split or at the bottom.
Testing:
Create an article with some tags and mark it featured.
Create a menu item Featured Article and select the category of the article created
Verify tags are shown with info block at bottom and split (at the bottom)
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Layout |
This PR is fixing a regression. It doesn't change existing functionality. Assuming difference is by design.
@test works fine for me. In my case the tags are also no shown when info block is configured on top. If more people have that problem, can you fix that to?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6625.
@n9iels @sovainfo can you try to fix the issue by adding using this:
<?php if ($params->get('show_tags', 1) && !empty($this->item->tags->itemTags)) : ?>
<?php echo JLayoutHelper::render('joomla.content.tags', $this->item->tags->itemTags); ?>
<?php endif; ?>
Also after this line: https://github.com/joomla/joomla-cms/pull/6625/files#diff-668a86a17298895a6f00030d59e0e937R56
@test I tested the solution of @zero-24. When you configured the info block as split the tags are displayed twice, above and below the article
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6625.
@n9iels @zero-24 As already mentioned this is a regression PR. That means it fixes a bug introduced by a previous PR. That PR did not have the intention to change anything. It was a technical improvement. Unfortunately it removed showing the tags. This PR restores that.
What you are requesting is a change in functionality. Regardless of whether I agree on that request or not, it doesn't fit into this PR.
This PR shouldn't change the behaviour, it restores the behaviour as it was before #4397
| Status | Pending | ⇒ | Ready to Commit |
Thanks @sovainfo moving here to RTC. @n9iels can you open a new Issue for the dublicate tags?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6625.
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-04-04 12:49:41 |
Thank you all
| Labels |
Removed:
?
|
||
@test Setting ABOVE doesn't display tags.
Blog and Featured View work different now.
#6624 (comment)