Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#6612] - Handle DB errors in authentication cookie plugin

? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
30 Mar 2015

Database errors are uncaught/unmanaged in the authentication cookie plugin right now. This PR adds error handling for the plugin by catching exceptions thrown by the database layer and deciding how to proceed.

Testing Instructions

Generally just make sure the plugin still works.

avatar mbabker mbabker - open - 30 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 30 Mar 2015
Easy No ⇒ Yes
avatar zero-24 zero-24 - change - 30 Mar 2015
Category ⇒ Authentication Plugins
avatar wilsonge wilsonge - change - 1 Apr 2015
Milestone Added:
avatar alikon
alikon - comment - 1 Apr 2015

@test works for me
but not so sure how to simulate properly i've just mispelled some fieldname in some queries

avatar alikon alikon - reference | - 1 Apr 15
avatar alikon alikon - reference | - 5 Apr 15
avatar alikon alikon - reference | - 5 Apr 15
avatar alikon alikon - reference | - 6 Apr 15
avatar alikon alikon - reference | - 6 Apr 15
avatar alikon alikon - reference | - 8 Apr 15
avatar alikon alikon - reference | - 8 Apr 15
avatar alikon alikon - reference | - 8 Apr 15
avatar sovainfo
sovainfo - comment - 8 Apr 2015

Disagree on not being interested in failures. Suggest logging the error to inform webmaster.

avatar mbabker
mbabker - comment - 8 Apr 2015

JDatabase already has logging mechanisms built into the driver execute methods, you just need to have a logger enabled and listening to the databasequery category. So I don't think we need to duplicate that into the plugin here. That leaves this PR to just catch exceptions and decide whether the error is fatal to execution or if it can keep going.

avatar alikon alikon - reference | c0f1194 - 8 Apr 15
avatar alikon alikon - reference | 3fa79ac - 8 Apr 15
avatar alikon alikon - reference | 5a3328c - 8 Apr 15
avatar roland-d
roland-d - comment - 9 Jun 2015

@mbabker Please provide clear test instructions. With 2 people we have been unable to figure out how this should be tested. Thanks.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6612.

avatar mbabker
mbabker - comment - 9 Jun 2015

I don't have anything to give for instructions. I don't know how you can actually trigger the errors that are being caught here in normal system operation to validate "sensitive" data is masked or the error conditions are correctly executed, the only thing I can suggest is that you enable cookie authentication and make sure the success paths work right.

avatar roland-d
roland-d - comment - 9 Jun 2015

In that case, I can say testing is OK. We tried a lot of ways to get an error but things kept working :)

avatar roland-d roland-d - test_item - 9 Jun 2015 - Tested successfully
avatar designbengel
designbengel - comment - 9 Jun 2015

:-) same here - didn´t get errors

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6612.

avatar designbengel designbengel - test_item - 9 Jun 2015 - Tested successfully
avatar zero-24 zero-24 - change - 9 Jun 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 9 Jun 2015

RTC :smile: Thanks for testing and coding

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6612.

avatar zero-24 zero-24 - change - 9 Jun 2015
Labels Added: ?
avatar roland-d roland-d - change - 9 Jun 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-06-09 19:49:05
Closed_By ⇒ roland-d
avatar roland-d roland-d - close - 9 Jun 2015
avatar zero-24 zero-24 - close - 9 Jun 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment