? ? Pending

User tests: Successful: Unsuccessful:

avatar jsubri
jsubri
29 Mar 2015

Trying to update a template in an unwritable directory COM_TEMPLATES_FILE_PERMISSIONS message is not displayed.

com_templates_file_permissions-before

after the patch

com_templates_file_permissions-after

avatar jsubri jsubri - open - 29 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 29 Mar 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 29 Mar 2015
Easy No Yes
avatar zero-24 zero-24 - change - 29 Mar 2015
Category Administration Language & Strings
avatar infograf768
infograf768 - comment - 30 Mar 2015

This is not language friendly: the variable should be displayed depending on the language.
Patch should be imho:

diff --git a/administrator/components/com_templates/models/template.php b/administrator/components/com_templates/models/template.php
index b88b615..d75b735 100644
--- a/administrator/components/com_templates/models/template.php
+++ b/administrator/components/com_templates/models/template.php
@@ -494,5 +494,5 @@
        {
            $app->enqueueMessage(JText::_('COM_TEMPLATES_ERROR_SOURCE_FILE_NOT_WRITABLE'), 'warning');
-           $app->enqueueMessage(JText::_('COM_TEMPLATES_FILE_PERMISSIONS' . JPath::getPermissions($filePath)), 'warning');
+           $app->enqueueMessage(JText::sprintf('COM_TEMPLATES_FILE_PERMISSIONS', JPath::getPermissions($filePath)), 'warning');

            if (!JPath::isOwner($filePath))
diff --git a/administrator/language/en-GB/en-GB.com_templates.ini b/administrator/language/en-GB/en-GB.com_templates.ini
index 9591641..a00c4a1 100644
--- a/administrator/language/en-GB/en-GB.com_templates.ini
+++ b/administrator/language/en-GB/en-GB.com_templates.ini
@@ -117,5 +117,5 @@
 COM_TEMPLATES_FILE_INFO="File Information"
 COM_TEMPLATES_FILE_NAME="File Name"
-COM_TEMPLATES_FILE_PERMISSIONS="The File Permissions are "
+COM_TEMPLATES_FILE_PERMISSIONS="The File Permissions are %s"
 COM_TEMPLATES_FILE_RENAME_ERROR="An error occurred renaming the file."
 COM_TEMPLATES_FILE_RENAME_SUCCESS="File renamed successfully."
avatar jsubri
jsubri - comment - 30 Mar 2015

Implemented suggestions, thank you.

avatar infograf768
infograf768 - comment - 31 Mar 2015

:+1:

avatar brianteeman
brianteeman - comment - 24 May 2015

Setting the protostar folder to unwritable I have only been able to display the error message and not the warning


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6609.

avatar jsubri
jsubri - comment - 24 May 2015

@Brianteeman, Thank you for testing.
You are not wrong, the Error message is displayed when the directory is unwritable, Warning appears at the file level.

Full test:
set 777 recursive to /administrator/templates/hathor
set 755 to administrator/templates/hathor.dir
set 755 or 644 to administrator/templates/hathor/component.php
updating administrator/templates/hathor/component.php you should get both Error and Warning

line 496 should have a comma and not a dot to get the message evaluated.
Tks

avatar brianteeman
brianteeman - comment - 25 May 2015

Sorry I still cant replicate it with those instructions

On 24 May 2015 at 16:50, Jean-Luc Subri notifications@github.com wrote:

@Brianteeman https://github.com/Brianteeman, Thank you for testing.
You are not wrong, the Error message is displayed when the directory is
unwritable, Warning appears at the file level.

Full test:
set 777 recursive to /administrator/templates/hathor
set 755 to administrator/templates/hathor.dir
set 755 or 644 to administrator/templates/hathor/component.php
updating administrator/templates/hathor/component.php you should get both
Error and Warning

line 496 should have a comma and not a dot to get the message evaluated.
Tks


Reply to this email directly or view it on GitHub
#6609 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar Bloggerschmidt
Bloggerschmidt - comment - 24 Oct 2015

I'm sorry, but I can't reproduced this issue with the test instructions above, so hathor.dir file or dir doesn't exists. Hm.

avatar svom
svom - comment - 24 Oct 2015

I'm not able to reproduce this issue with the instructions above.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6609.

avatar designbengel
designbengel - comment - 24 Oct 2015

Can´t reproduce the issue. Got the message: Error
The template folder is not writable. Some features may not work.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6609.

avatar jsubri
jsubri - comment - 25 Oct 2015

Thank you for testing.
Reading your comments, you are all receiving the Error message but none of you is entering the condition on line 493 => "if (!is_writable($filePath))"

With my hoster, the customers are receiving user/group "customer-xx/webusers" while Apache is running under "webserverd/webserverd".

Might be the best way to get the Warning is to comment out the line 493 and testing again!
Best


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6609.

avatar RickR2H
RickR2H - comment - 15 Apr 2016

I could reproduce the error by using this procedure:
Set the folder permissons of the Protostar template to 755 (Normal Apache rights)
Open the protostar template and edit a file from the internal template editor and make a small change. Don't press save yet!
Next, change the folder permissions of the protostar template to 444
Now go back and press Save to store the changes
The error will now occur.

The only thing is that the folder rights are only dashes like: ---------
screen shot 2016-04-15 at 08 01 08

But the translations is fixed


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6609.

avatar RickR2H RickR2H - test_item - 15 Apr 2016 - Tested successfully
avatar RickR2H
RickR2H - comment - 15 Apr 2016

I have tested this item :white_check_mark: successfully on 6888366

See my previous post...


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6609.

avatar designbengel
designbengel - comment - 15 Apr 2016

Before: Source file not writable.
COM_TEMPLATES_FILE_PERMISSIONSr--r--r--
Could not save data. Error:

After: Source file not writable.
The File Permissions are r--r--r--
Could not save data. Error:

But isn´t there something missing after "Error:" ?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6609.

avatar brianteeman
brianteeman - comment - 15 Apr 2016

yes something is missing

On 15 April 2016 at 14:12, designbengel notifications@github.com wrote:

Before: Source file not writable.
COM_TEMPLATES_FILE_PERMISSIONSr--r--r--
Could not save data. Error:

After: Source file not writable.
The File Permissions are r--r--r--
Could not save data. Error:

But isn´t there something missing after "Error:" ?

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/6609
https://issues.joomla.org/tracker/joomla-cms/6609.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6609 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar smz
smz - comment - 15 Apr 2016

Nitpicking: either this is an error or this is a warning: in both cases I think wording and alert class (color) should be consistent.

avatar henkrijneveld henkrijneveld - test_item - 15 Apr 2016 - Tested unsuccessfully
avatar henkrijneveld
henkrijneveld - comment - 15 Apr 2016

I have tested this item :red_circle: unsuccessfully on 6888366

BEFORE:
Warning
Source file not writable.
COM_TEMPLATES_FILE_PERMISSIONSr--r--r--
Could not save data. Error:

AFTER
Warning
Source file not writable.
The File Permissions are r--r--r--
Could not save data. Error:

apart from the upper to lowercase no difference. more work needed.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6609.

avatar conconnl conconnl - test_item - 25 Jun 2016 - Tested successfully
avatar conconnl
conconnl - comment - 25 Jun 2016

I have tested this item successfully on 6888366

Tested the patch successfully.
The language string is working again.

Before and After the patch the file permissions were written like: ------
Before and After the patch the Error: is empty

There are other errors but not because of the patch


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6609.

avatar pjasmits
pjasmits - comment - 25 Jun 2016

Found some missing strings in the file: en-GB.com_templates.ini

COM_TEMPLATES_STYLES_PAGES_ALL="Default for all pages"
COM_TEMPLATES_STYLES_PAGES_NONE="Not assigned"
COM_TEMPLATES_MANAGER_STYLES_SITE="Templates: Styles (Site)"
COM_TEMPLATES_HEADING_PAGES="Pages"
COM_TEMPLATES_MANAGER_TEMPLATES_SITE="Templates: Templates (Site)"
COM_TEMPLATES_HEADING_ASSIGNED="Assigned"
COM_TEMPLATES_HEADING_DEFAULT="Default"
COM_TEMPLATES_HEADING_DEFAULT_ASC="Default ascending"
COM_TEMPLATES_HEADING_DEFAULT_DESC="Default descending"
COM_TEMPLATES_HEADING_IMAGE="Image"
COM_TEMPLATES_HEADING_LOCATION_ASC="Location ascending"
COM_TEMPLATES_HEADING_LOCATION_DESC="Location descending"
COM_TEMPLATES_HEADING_PAGES="Pages"
COM_TEMPLATES_HEADING_STYLE="Style"
COM_TEMPLATES_HEADING_STYLE_ASC="Style ascending"
COM_TEMPLATES_HEADING_STYLE_DESC="Style descending"
COM_TEMPLATES_HEADING_TEMPLATE="Template"
COM_TEMPLATES_HEADING_TEMPLATE_ASC="Template ascending"
COM_TEMPLATES_HEADING_TEMPLATE_DESC="Template descending"
COM_TEMPLATES_STYLES_PAGES_SELECTED="Assigned on %s pages"

screen shot 2016-06-25 at 06 29 35

Test is successful some work needs to be done in the file en-GB.com_templates.ini

Tested on the 3.6.0 beta 2.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6609.

avatar pjasmits pjasmits - test_item - 25 Jun 2016 - Tested unsuccessfully
avatar pjasmits pjasmits - test_item - 25 Jun 2016 - Tested successfully
avatar pjasmits
pjasmits - comment - 25 Jun 2016

I have tested this item successfully on 6888366


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6609.

avatar roland-d roland-d - change - 25 Jun 2016
Milestone Added:
avatar roland-d roland-d - change - 25 Jun 2016
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2016
Milestone Removed:
avatar zero-24
zero-24 - comment - 25 Jun 2016

@joomla-cms-bot please help me ?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6609.

avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2016
Labels Added: ?
avatar infograf768
infograf768 - comment - 26 Jun 2016

@pjasmits

These strings are present in staging/3.6.0 beta

avatar jsubri
jsubri - comment - 26 Jun 2016

Thank you all for your tests.
Best

avatar zero-24
zero-24 - comment - 26 Jun 2016

@roland-d can You re-add the milestone? I have called the bot too fast yesterday ;)

avatar roland-d roland-d - change - 26 Jun 2016
Milestone Added:
avatar wilsonge wilsonge - change - 21 Jul 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-07-21 20:37:18
Closed_By wilsonge
avatar zero-24
zero-24 - comment - 21 Jul 2016

@joomla-cms-bot did i something wrong? Why you don't help me?

avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment