User tests: Successful: Unsuccessful:
Labels |
Added:
?
|
Easy | No | ⇒ | Yes |
Category | ⇒ | Administration Language & Strings |
Implemented suggestions, thank you.
Setting the protostar folder to unwritable I have only been able to display the error message and not the warning
@Brianteeman, Thank you for testing.
You are not wrong, the Error message is displayed when the directory is unwritable, Warning appears at the file level.
Full test:
set 777 recursive to /administrator/templates/hathor
set 755 to administrator/templates/hathor.dir
set 755 or 644 to administrator/templates/hathor/component.php
updating administrator/templates/hathor/component.php you should get both Error and Warning
line 496 should have a comma and not a dot to get the message evaluated.
Tks
Sorry I still cant replicate it with those instructions
On 24 May 2015 at 16:50, Jean-Luc Subri notifications@github.com wrote:
@Brianteeman https://github.com/Brianteeman, Thank you for testing.
You are not wrong, the Error message is displayed when the directory is
unwritable, Warning appears at the file level.Full test:
set 777 recursive to /administrator/templates/hathor
set 755 to administrator/templates/hathor.dir
set 755 or 644 to administrator/templates/hathor/component.php
updating administrator/templates/hathor/component.php you should get both
Error and Warningline 496 should have a comma and not a dot to get the message evaluated.
Tks—
Reply to this email directly or view it on GitHub
#6609 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I'm sorry, but I can't reproduced this issue with the test instructions above, so hathor.dir file or dir doesn't exists. Hm.
I'm not able to reproduce this issue with the instructions above.
Can´t reproduce the issue. Got the message: Error
The template folder is not writable. Some features may not work.
Thank you for testing.
Reading your comments, you are all receiving the Error message but none of you is entering the condition on line 493 => "if (!is_writable($filePath))"
With my hoster, the customers are receiving user/group "customer-xx/webusers" while Apache is running under "webserverd/webserverd".
Might be the best way to get the Warning is to comment out the line 493 and testing again!
Best
I could reproduce the error by using this procedure:
Set the folder permissons of the Protostar template to 755 (Normal Apache rights)
Open the protostar template and edit a file from the internal template editor and make a small change. Don't press save yet!
Next, change the folder permissions of the protostar template to 444
Now go back and press Save to store the changes
The error will now occur.
The only thing is that the folder rights are only dashes like: ---------
But the translations is fixed
I have tested this item successfully on 6888366
See my previous post...
Before: Source file not writable.
COM_TEMPLATES_FILE_PERMISSIONSr--r--r--
Could not save data. Error:
After: Source file not writable.
The File Permissions are r--r--r--
Could not save data. Error:
But isn´t there something missing after "Error:" ?
yes something is missing
On 15 April 2016 at 14:12, designbengel notifications@github.com wrote:
Before: Source file not writable.
COM_TEMPLATES_FILE_PERMISSIONSr--r--r--
Could not save data. Error:After: Source file not writable.
The File Permissions are r--r--r--
Could not save data. Error:But isn´t there something missing after "Error:" ?
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/6609
https://issues.joomla.org/tracker/joomla-cms/6609.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6609 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Nitpicking: either this is an error or this is a warning: in both cases I think wording and alert class (color) should be consistent.
I have tested this item unsuccessfully on 6888366
BEFORE:
Warning
Source file not writable.
COM_TEMPLATES_FILE_PERMISSIONSr--r--r--
Could not save data. Error:
AFTER
Warning
Source file not writable.
The File Permissions are r--r--r--
Could not save data. Error:
apart from the upper to lowercase no difference. more work needed.
I have tested this item
Tested the patch successfully.
The language string is working again.
Before and After the patch the file permissions were written like: ------
Before and After the patch the Error: is empty
There are other errors but not because of the patch
Found some missing strings in the file: en-GB.com_templates.ini
COM_TEMPLATES_STYLES_PAGES_ALL="Default for all pages"
COM_TEMPLATES_STYLES_PAGES_NONE="Not assigned"
COM_TEMPLATES_MANAGER_STYLES_SITE="Templates: Styles (Site)"
COM_TEMPLATES_HEADING_PAGES="Pages"
COM_TEMPLATES_MANAGER_TEMPLATES_SITE="Templates: Templates (Site)"
COM_TEMPLATES_HEADING_ASSIGNED="Assigned"
COM_TEMPLATES_HEADING_DEFAULT="Default"
COM_TEMPLATES_HEADING_DEFAULT_ASC="Default ascending"
COM_TEMPLATES_HEADING_DEFAULT_DESC="Default descending"
COM_TEMPLATES_HEADING_IMAGE="Image"
COM_TEMPLATES_HEADING_LOCATION_ASC="Location ascending"
COM_TEMPLATES_HEADING_LOCATION_DESC="Location descending"
COM_TEMPLATES_HEADING_PAGES="Pages"
COM_TEMPLATES_HEADING_STYLE="Style"
COM_TEMPLATES_HEADING_STYLE_ASC="Style ascending"
COM_TEMPLATES_HEADING_STYLE_DESC="Style descending"
COM_TEMPLATES_HEADING_TEMPLATE="Template"
COM_TEMPLATES_HEADING_TEMPLATE_ASC="Template ascending"
COM_TEMPLATES_HEADING_TEMPLATE_DESC="Template descending"
COM_TEMPLATES_STYLES_PAGES_SELECTED="Assigned on %s pages"
Test is successful some work needs to be done in the file en-GB.com_templates.ini
Tested on the 3.6.0 beta 2.
I have tested this item
Milestone |
Added: |
Status | Pending | ⇒ | Ready to Commit |
Milestone |
Removed: |
@joomla-cms-bot please help me
Labels |
Added:
?
|
Labels |
Added:
?
|
Thank you all for your tests.
Best
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-21 20:37:18 |
Closed_By | ⇒ | wilsonge |
@joomla-cms-bot did i something wrong? Why you don't help me?
Labels |
Removed:
?
|
This is not language friendly: the variable should be displayed depending on the language.
Patch should be imho: