Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#6595] - Introduce modal footer with close button for bootstrap modals

? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
27 Mar 2015

Minor UX/UI

This PR will attaches a footer on users notes and multilingual status modals

Preview

User notes
screen shot 2015-03-27 at 3 01 04

Multilingual status
screen shot 2015-03-27 at 3 03 02

Testing

Apply patch
goto /administrator/index.php?option=com_users&view=users
and click on multilingual status on the status bar
make sure that the close button closes the modal

I will update also #6408 and #4661
For #4563 PR #6462 needs to be accepted first.
The rest #5871, #5655, #5654 and #5652 needs the new layout render, so I will not touch them yet

avatar dgt41 dgt41 - open - 27 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 27 Mar 2015
Labels Added: ?
avatar n9iels
n9iels - comment - 27 Mar 2015

Thanks! very good addition :-D

@test successful, only the same points I noticed also in another patch: I see two scrollbars, and maybe it should be nice if you can disable scrolling of the background.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6595.
avatar n9iels n9iels - test_item - 27 Mar 2015 - Tested successfully
avatar zero-24 zero-24 - change - 27 Mar 2015
Easy No ⇒ Yes
avatar zero-24 zero-24 - change - 27 Mar 2015
Category ⇒ Templates (admin) UI/UX
avatar dgt41
dgt41 - comment - 27 Mar 2015

Thanks @n9iels .what browser gives you the double scroll bar?

avatar n9iels
n9iels - comment - 27 Mar 2015

The latest version of Google Chrome

avatar dgt41
dgt41 - comment - 27 Mar 2015

It should be fixed now, Also the static background is not implemented in BS 2.3.2 so we have to come around with a hack, either css or js...

avatar n9iels
n9iels - comment - 28 Mar 2015

@test yes, that solves the issue.

I took a look at the modal on BS3. If you can add the class modal-open to the body when the modal is open, overflow:hidden; must be enough to disable scrolling for the background.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6595.
avatar superknutsel
superknutsel - comment - 10 Apr 2015

@test successful

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6595.

avatar superknutsel superknutsel - test_item - 10 Apr 2015 - Tested successfully
avatar dam-man
dam-man - comment - 10 Apr 2015

@test
issue has been fixed with this patch

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6595.

avatar zero-24 zero-24 - change - 10 Apr 2015
Status Pending ⇒ Ready to Commit
avatar dam-man dam-man - test_item - 10 Apr 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 10 Apr 2015

RTC Thanks for testing and coding here :smile:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6595.

avatar zero-24 zero-24 - change - 10 Apr 2015
Labels Added: ?
avatar roland-d roland-d - change - 10 Apr 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-04-10 14:37:19
avatar roland-d roland-d - close - 10 Apr 2015
avatar roland-d roland-d - close - 10 Apr 2015
avatar zero-24 zero-24 - close - 10 Apr 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment