User tests: Successful: Unsuccessful:
The error message also appears when the module is installed but not published/created.
Labels |
Added:
?
|
In the module manager if I do a search for modules that are not published they appear - see screenshot - so where are you seeing the need for this message
Status | Pending | ⇒ | Information Required |
Ah I see what you mean now. You are correct the current string is wrong
"There are no modules installed matching your query"
That is wrong as it implies that the module is not installed on the site.
Where what it actually means is that you do not have an instance of a
module with a title that matches. If you look at the tooltip for the search
box it indicates that the search is a "search in module title"
The search is for the title of the module and not the type of the module.
The string does need changing but your suggestion is not correct.
Perhaps it should be something like
"There are no modules created on this site with a title that matches the
query"
I am not 100% happy with that but I think it better describes the scenario
and addresses the problem you correctly found
On 23 March 2015 at 13:18, chmst notifications@github.com wrote:
Try as for example the filter type for "user-login" or "who is online".
See my screen. But you are righ. I'll try to find out why these modules are
not found in the database.
[image: module_manager]
https://cloud.githubusercontent.com/assets/1035262/6780649/74419f36-d167-11e4-9f76-307bc3776deb.PNG—
Reply to this email directly or view it on GitHub
#6551 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Thinking about it I think the best string to match the expected behaviour of the search box would simply be
"There are no modules that match your query"
Thoughts? I can create the PR if you think that message is the clearest to match the expected behaviour of the search functionality on that page
Status | Information Required | ⇒ | Confirmed |
Hi, thank you - thats better. I tried to find out why the query ist sometimes successful and sometimes it is not because it fails only for some types of modules. It has to do with dth client_id of the module. As for now - yes, please take your string for a PR, it is better than mine.
Thanks. Will create a PR shortly.
Regarding the client_id that is to be expected as there is always a filter applied in the module manager of either site or admin
See #6558
Status | Confirmed | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-24 08:19:41 |
Status | Closed | ⇒ | New |
Status | New | ⇒ | Closed |
Closed_Date | 2015-03-24 08:19:41 | ⇒ | 2015-03-24 09:28:44 |
Closing in favour of Brians
Where does this error message occur
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6551.