[#6548] - Fix pagination broken for articles view
- Closed
- 9 Apr 2015
- Medium
- Build: staging
- Easy Test
- # 6548
- Diff
- joomdonation:patch-4
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Please see #6544 for description of the issue. I just removed the code which is not needed anymore because the model states will be populated automatically in JModelList class using this block of code:
https://github.com/joomla/joomla-cms/blob/staging/libraries/legacy/model/list.php#L471-L477
Keep these lines of code will cause pagination always reset to first page and you could not move to any other pages.
If this PR is valid, we will need to fix all other core components as well.
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
Successful test for com_content here.
Thanks @alikon and @infograf768 for testing. I think we will need few more tests, then start working on other components.
@joomdonation that shit code was re-added after issues reported in Hathor. So ensure it works there.
wilsonge
- | Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Rel_Number | ⇒ | 6544 | |
| Relation Type | ⇒ | Pull Request for | |
| Easy | No | ⇒ | Yes |
Hathor will work as how it was working before with this PR. I think I won't look at the issue with Hathor for now. If this PR is accepted, I will need to work the same bugs on all other core components.
| Category | ⇒ | Administration |
RTC here. Thanks! @joomdonation can you do the PR for the other affected views?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6548.
brianteeman
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
Sorry for lately response. I am still waiting to see whether @phproberto could find a "real" backward compatible solution to this problem.
The real reason of this issue here is that right now, we have inconsistent state names between hathor and isis template. In hathor, the variable is filter_search but in isis, it is filtersearch. Because of this inconsistent:
- We have bugs
- We have duplicate code
Maybe we can modify hathor so that we can have same state variables ? Is it worth the effort as I see that there was propose to remove Hathor from Joomla core ?
| Labels |
Removed:
?
|
||
| Labels |
Removed:
?
|
||
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
| Labels |
Removed:
?
|
||
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
| Labels |
Removed:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-04-09 12:21:39 |
| Milestone |
Removed: |
||
@test success with Postgresql
as already stated we need to fix on all core components where the search tool is used