? Success
Pull Request for # 6544

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
23 Mar 2015

Please see #6544 for description of the issue. I just removed the code which is not needed anymore because the model states will be populated automatically in JModelList class using this block of code:

https://github.com/joomla/joomla-cms/blob/staging/libraries/legacy/model/list.php#L471-L477

Keep these lines of code will cause pagination always reset to first page and you could not move to any other pages.

If this PR is valid, we will need to fix all other core components as well.

avatar joomdonation joomdonation - open - 23 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 23 Mar 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 23 Mar 2015
Labels Added: ?
avatar alikon
alikon - comment - 23 Mar 2015

@test success with Postgresql
as already stated we need to fix on all core components where the search tool is used

avatar infograf768
infograf768 - comment - 23 Mar 2015

Successful test for com_content here.

avatar joomdonation
joomdonation - comment - 23 Mar 2015

Thanks @alikon and @infograf768 for testing. I think we will need few more tests, then start working on other components.

avatar phproberto
phproberto - comment - 23 Mar 2015

@joomdonation that shit code was re-added after issues reported in Hathor. So ensure it works there.

avatar wilsonge wilsonge - change - 24 Mar 2015
Milestone Added:
avatar bertmert
bertmert - comment - 25 Mar 2015

@test Success with com_content. Also Hathor.
(In Hathor there's an issue with filter "Display #" but also without this patch. Had a value "5" and cannot set it to another value.)

avatar zero-24 zero-24 - change - 25 Mar 2015
Status Pending Ready to Commit
Rel_Number 6544
Relation Type Pull Request for
Easy No Yes
avatar joomdonation
joomdonation - comment - 25 Mar 2015

Hathor will work as how it was working before with this PR. I think I won't look at the issue with Hathor for now. If this PR is accepted, I will need to work the same bugs on all other core components.

avatar zero-24 zero-24 - change - 27 Mar 2015
Category Administration
avatar zero-24
zero-24 - comment - 27 Mar 2015

RTC here. Thanks! @joomdonation can you do the PR for the other affected views?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6548.
avatar brianteeman brianteeman - change - 27 Mar 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 27 Mar 2015
Labels Added: ?
avatar joomdonation
joomdonation - comment - 2 Apr 2015

Sorry for lately response. I am still waiting to see whether @phproberto could find a "real" backward compatible solution to this problem.

The real reason of this issue here is that right now, we have inconsistent state names between hathor and isis template. In hathor, the variable is filter_search but in isis, it is filtersearch. Because of this inconsistent:

  • We have bugs
  • We have duplicate code

Maybe we can modify hathor so that we can have same state variables ? Is it worth the effort as I see that there was propose to remove Hathor from Joomla core ?

avatar phproberto
phproberto - comment - 6 Apr 2015

Please test #6677

It should replace this fix.

avatar phproberto phproberto - change - 6 Apr 2015
Labels Removed: ?
avatar phproberto phproberto - change - 6 Apr 2015
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 6 Apr 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 6 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 6 Apr 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 6 Apr 2015
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 6 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 6 Apr 2015
Status Ready to Commit Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 6 Apr 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 6 Apr 2015
Labels Removed: ?
avatar joomdonation joomdonation - change - 9 Apr 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-04-09 12:21:39
avatar joomdonation joomdonation - close - 9 Apr 2015
avatar joomdonation joomdonation - close - 9 Apr 2015
avatar zero-24 zero-24 - change - 6 May 2015
Milestone Removed:
avatar joomdonation joomdonation - head_ref_deleted - 19 Dec 2015

Add a Comment

Login with GitHub to post a comment